Re: [patch] Bluetooth: ath3k: Silence uninitialized variable warning

2016-04-23 Thread Dan Carpenter
On Sat, Apr 23, 2016 at 12:17:45PM +0530, Afzal Mohammed wrote: > Hi, > > On Fri, Apr 22, 2016 at 01:02:55PM +0300, Dan Carpenter wrote: > > > - int err, pipe, len, size, count, sent = 0; > > + int len = 0; > > + int err, pipe, size, count, sent = 0; > > Is there any particular reason to a

Re: [patch] Bluetooth: ath3k: Silence uninitialized variable warning

2016-04-22 Thread Afzal Mohammed
Hi, On Fri, Apr 22, 2016 at 01:02:55PM +0300, Dan Carpenter wrote: > - int err, pipe, len, size, count, sent = 0; > + int len = 0; > + int err, pipe, size, count, sent = 0; Is there any particular reason to avoid more than 1 variable initialization in definition on a single line ?, l

Re: [patch] Bluetooth: ath3k: Silence uninitialized variable warning

2016-04-22 Thread Marcel Holtmann
Hi Dan, > We could print an uninitialized value in the error message. > > Signed-off-by: Dan Carpenter patch has been applied to bluetooth-next tree. Regards Marcel

[patch] Bluetooth: ath3k: Silence uninitialized variable warning

2016-04-22 Thread Dan Carpenter
We could print an uninitialized value in the error message. Signed-off-by: Dan Carpenter diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c index 47ca4b3..641c2d1 100644 --- a/drivers/bluetooth/ath3k.c +++ b/drivers/bluetooth/ath3k.c @@ -206,7 +206,8 @@ static int ath3k_load_firm