Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND

2016-03-15 Thread Dmitry Torokhov
On Tue, Mar 15, 2016 at 02:20:02PM -0700, Andrew Duggan wrote: > On 03/15/2016 12:11 AM, Dan Carpenter wrote: > >There is a typo so we have && instead of &. > > > >Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and > >F11') > >Signed-off-by: Dan Carpenter > > Acked-by:

Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND

2016-03-15 Thread Andrew Duggan
On 03/15/2016 12:11 AM, Dan Carpenter wrote: There is a typo so we have && instead of &. Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11') Signed-off-by: Dan Carpenter Acked-by: Andrew Duggan diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/r

Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND

2016-03-15 Thread Joe Perches
On Tue, 2016-03-15 at 11:37 +0300, Dan Carpenter wrote: > On Tue, Mar 15, 2016 at 01:33:29AM -0700, Joe Perches wrote: > > > > Right and as well these are bool so the !! isn't necessary. > Not necessary but nice for reading... opinions vary. cheers, Joe

Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND

2016-03-15 Thread Dan Carpenter
On Tue, Mar 15, 2016 at 01:33:29AM -0700, Joe Perches wrote: > Right and as well these are bool so the !! isn't necessary. Not necessary but nice for reading... regards, dan carpenter

Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND

2016-03-15 Thread Joe Perches
On Tue, 2016-03-15 at 10:11 +0300, Dan Carpenter wrote: > There is a typo so we have && instead of &. > > Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and > F11') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f1

[patch] Input: synaptics-rmi4 - using logical instead of bitwise AND

2016-03-15 Thread Dan Carpenter
There is a typo so we have && instead of &. Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11') Signed-off-by: Dan Carpenter diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c index 77a5eb8..ec8a10d 100644 --- a/drivers/input/rmi4/rmi_f11.c +