Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-28 Thread Kay Sievers
On Tue, 2007-06-26 at 11:46 +0100, Richard Hughes wrote: > On Tue, 2007-06-26 at 11:02 +0100, Richard Purdie wrote: > > There were some other opinions voiced including one from the person > > who started this discussion. > > > > So no, the people who write the tools that parse sysfs (like HAL.) >

Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-26 Thread Richard Hughes
On Tue, 2007-06-26 at 11:02 +0100, Richard Purdie wrote: > There were some other opinions voiced including one from the person > who started this discussion. > > So no, the people who write the tools that parse sysfs (like HAL.) > don't appreciate this. > > People who write tools that parse sysfs

Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-26 Thread Richard Purdie
On Sun, 2007-06-24 at 22:06 -0700, Greg KH wrote: > On Sat, Jun 09, 2007 at 10:25:16AM +0100, Richard Purdie wrote: > > Anyhow, time to stop pretending I have any choice in this ;-). I will > > have the LED class use random numbers for busids and add a name > > attribute unless anyone else voices a

Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-24 Thread Greg KH
On Sat, Jun 09, 2007 at 10:25:16AM +0100, Richard Purdie wrote: > Anyhow, time to stop pretending I have any choice in this ;-). I will > have the LED class use random numbers for busids and add a name > attribute unless anyone else voices an opinion. Thank you, I really appreciate it, and so does

Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-10 Thread Henrique de Moraes Holschuh
Hi Richard! On Sun, 10 Jun 2007, Richard Hughes wrote: > On Sun, 2007-06-10 at 12:11 +0200, Pavel Machek wrote: > > Can we keep the original naming? spitz:disk is as unique as led02, and > > it is _way_ easier to use. > > Come on, I want to use the led subsystem from the scripts... > > I don't

Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-10 Thread Richard Hughes
On Sun, 2007-06-10 at 12:11 +0200, Pavel Machek wrote: > Can we keep the original naming? spitz:disk is as unique as led02, and > it is _way_ easier to use. > Come on, I want to use the led subsystem from the scripts... I don't see a problem with spitz_disk, which is just as easy to use in script

Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-10 Thread Pavel Machek
Hi! > > My other concerns with this patch are that it exports incorrect > > information on spitz (which I had warned about and I will get bug > > reports about) and that "description" is not really a suitable name for > > a sysfs attribute, "function" might give a better idea of what it > > repres

Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-09 Thread Richard Purdie
On Fri, 2007-06-08 at 16:46 -0700, Greg KH wrote: > On Sat, Jun 09, 2007 at 12:02:28AM +0100, Richard Purdie wrote: > > On Fri, 2007-06-08 at 11:57 -0700, Greg KH wrote: > > > On Fri, Jun 01, 2007 at 05:23:24PM +0100, Richard Purdie wrote: > > > Why not just do a simple: > > > led01 > > > led0

Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-08 Thread Greg KH
On Sat, Jun 09, 2007 at 12:02:28AM +0100, Richard Purdie wrote: > On Fri, 2007-06-08 at 11:57 -0700, Greg KH wrote: > > On Fri, Jun 01, 2007 at 05:23:24PM +0100, Richard Purdie wrote: > > > I still question whether either colour or function properties are > > > actually particularly useful to users

Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-08 Thread Richard Purdie
On Fri, 2007-06-08 at 11:57 -0700, Greg KH wrote: > On Fri, Jun 01, 2007 at 05:23:24PM +0100, Richard Purdie wrote: > > I still question whether either colour or function properties are > > actually particularly useful to userspace other than for naming purposes > > which is why they were part of t

Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-08 Thread Greg KH
On Fri, Jun 01, 2007 at 05:23:24PM +0100, Richard Purdie wrote: > On Fri, 2007-06-01 at 16:59 +0100, Richard Hughes wrote: > > On Fri, 2007-06-01 at 16:43 +0100, Richard Purdie wrote: > > > I accept this is basically out of my hands now. Greg/Kay have the > > > appropriate emails and if they'll let

Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-01 Thread Richard Purdie
On Fri, 2007-06-01 at 16:59 +0100, Richard Hughes wrote: > On Fri, 2007-06-01 at 16:43 +0100, Richard Purdie wrote: > > I accept this is basically out of my hands now. Greg/Kay have the > > appropriate emails and if they'll let me know which approach they want > > to take, I'll apply an appropriate

Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-01 Thread Richard Hughes
On Fri, 2007-06-01 at 16:43 +0100, Richard Purdie wrote: > On Fri, 2007-06-01 at 16:04 +0100, Richard Hughes wrote: > > Patch attached corrects all the brokenness with the led class (encoding > > some attributes in the device handle). > > For the benefit of LKML, there has been some discussion of

Re: [patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-01 Thread Richard Purdie
On Fri, 2007-06-01 at 16:04 +0100, Richard Hughes wrote: > Patch attached corrects all the brokenness with the led class (encoding > some attributes in the device handle). For the benefit of LKML, there has been some discussion of this elsewhere. My arguments do not particularly come across in Ric

[patch] Move led attributes out of device name and into sysfs attributes, was Re: LED devices

2007-06-01 Thread Richard Hughes
On Thu, 2007-05-31 at 00:24 -0700, Greg KH wrote: > On Wed, May 30, 2007 at 05:19:31PM +0100, Richard Purdie wrote: > > On Wed, 2007-05-30 at 16:34 +0100, Richard Hughes wrote: > > > I've talked with other kernel guys here at red hat and they don't think > > > putting properties in the handle is a