Looks good to me.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi!
> >>--- a/drivers/staging/tidspbridge/rmgr/drv_interface.c
> >>+++ b/drivers/staging/tidspbridge/rmgr/drv_interface.c
> >>@@ -258,7 +258,17 @@ err:
> >> /* This function maps kernel space memory to user space memory. */
> >> static int bridge_mmap(struct file *filp, struct vm_area_struct
On 01.12.2013 14:27, Dan Carpenter wrote:
On Sun, Dec 01, 2013 at 01:10:06PM +0100, Pavel Machek wrote:
diff --git a/drivers/staging/tidspbridge/rmgr/drv_interface.c
b/drivers/staging/tidspbridge/rmgr/drv_interface.c
index 1aa4a3f..a8e86cf 100644
---
On Sun, Dec 01, 2013 at 01:10:06PM +0100, Pavel Machek wrote:
> diff --git a/drivers/staging/tidspbridge/rmgr/drv_interface.c
> b/drivers/staging/tidspbridge/rmgr/drv_interface.c
> index 1aa4a3f..a8e86cf 100644
> --- a/drivers/staging/tidspbridge/rmgr/drv_interface.c
> +++
Hi!
> I can (and will) test whatever patches is needed. Also will try to get rid of
> uuid helpers and send a patch today.
>
So ... here's patch that you can start from, and that may even work...
Thanks,
Pavel
On Sunday 01 December 2013 12:26:10 Pavel Machek wrote:
> Hi!
>
> On Sat 2013-11-30 19:45:01, Greg KH wrote:
> > On Sat, Nov 30, 2013 at 11:58:23PM +0100, Pavel Machek wrote:
> > > On Sat 2013-11-30 14:05:53, Greg KH wrote:
> > > > On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek
wrote:
>
Hi!
On Sat 2013-11-30 19:45:01, Greg KH wrote:
> On Sat, Nov 30, 2013 at 11:58:23PM +0100, Pavel Machek wrote:
> > On Sat 2013-11-30 14:05:53, Greg KH wrote:
> > > On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek wrote:
> > > >
> > > > mmap in tidspbridge is missing range-checks. For now,
I can (and will) test whatever patches is needed. Also will try to get rid of
uuid helpers and send a patch today.
On Sun Dec 1 11:41:39 2013 Pali Rohár wrote:
> On Saturday 30 November 2013 23:58:23 Pavel Machek wrote:
> > On Sat 2013-11-30 14:05:53, Greg KH wrote:
> > > On Sat, Nov 30, 2013
On Sunday 01 December 2013 04:45:01 Greg KH wrote:
> On Sat, Nov 30, 2013 at 11:58:23PM +0100, Pavel Machek wrote:
> > On Sat 2013-11-30 14:05:53, Greg KH wrote:
> > > On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek wrote:
> > > > mmap in tidspbridge is missing range-checks. For now,
> > >
On Saturday 30 November 2013 23:58:23 Pavel Machek wrote:
> On Sat 2013-11-30 14:05:53, Greg KH wrote:
> > On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek wrote:
> > > mmap in tidspbridge is missing range-checks. For now, make
> > > this interface root-only, so that it does not cause
> > >
On Saturday 30 November 2013 23:58:23 Pavel Machek wrote:
On Sat 2013-11-30 14:05:53, Greg KH wrote:
On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek wrote:
mmap in tidspbridge is missing range-checks. For now, make
this interface root-only, so that it does not cause
security
On Sunday 01 December 2013 04:45:01 Greg KH wrote:
On Sat, Nov 30, 2013 at 11:58:23PM +0100, Pavel Machek wrote:
On Sat 2013-11-30 14:05:53, Greg KH wrote:
On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek wrote:
mmap in tidspbridge is missing range-checks. For now,
make this
I can (and will) test whatever patches is needed. Also will try to get rid of
uuid helpers and send a patch today.
On Sun Dec 1 11:41:39 2013 Pali Rohár pali.ro...@gmail.com wrote:
On Saturday 30 November 2013 23:58:23 Pavel Machek wrote:
On Sat 2013-11-30 14:05:53, Greg KH wrote:
On
Hi!
On Sat 2013-11-30 19:45:01, Greg KH wrote:
On Sat, Nov 30, 2013 at 11:58:23PM +0100, Pavel Machek wrote:
On Sat 2013-11-30 14:05:53, Greg KH wrote:
On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek wrote:
mmap in tidspbridge is missing range-checks. For now, make this
On Sunday 01 December 2013 12:26:10 Pavel Machek wrote:
Hi!
On Sat 2013-11-30 19:45:01, Greg KH wrote:
On Sat, Nov 30, 2013 at 11:58:23PM +0100, Pavel Machek wrote:
On Sat 2013-11-30 14:05:53, Greg KH wrote:
On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek
wrote:
mmap in
Hi!
I can (and will) test whatever patches is needed. Also will try to get rid of
uuid helpers and send a patch today.
So ... here's patch that you can start from, and that may even work...
Thanks,
Pavel
On Sun, Dec 01, 2013 at 01:10:06PM +0100, Pavel Machek wrote:
diff --git a/drivers/staging/tidspbridge/rmgr/drv_interface.c
b/drivers/staging/tidspbridge/rmgr/drv_interface.c
index 1aa4a3f..a8e86cf 100644
--- a/drivers/staging/tidspbridge/rmgr/drv_interface.c
+++
On 01.12.2013 14:27, Dan Carpenter wrote:
On Sun, Dec 01, 2013 at 01:10:06PM +0100, Pavel Machek wrote:
diff --git a/drivers/staging/tidspbridge/rmgr/drv_interface.c
b/drivers/staging/tidspbridge/rmgr/drv_interface.c
index 1aa4a3f..a8e86cf 100644
---
Hi!
--- a/drivers/staging/tidspbridge/rmgr/drv_interface.c
+++ b/drivers/staging/tidspbridge/rmgr/drv_interface.c
@@ -258,7 +258,17 @@ err:
/* This function maps kernel space memory to user space memory. */
static int bridge_mmap(struct file *filp, struct vm_area_struct *vma)
{
-
Looks good to me.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Sat, Nov 30, 2013 at 11:58:23PM +0100, Pavel Machek wrote:
> On Sat 2013-11-30 14:05:53, Greg KH wrote:
> > On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek wrote:
> > >
> > > mmap in tidspbridge is missing range-checks. For now, make this
> > > interface root-only, so that it does not
On Sat 2013-11-30 14:05:53, Greg KH wrote:
> On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek wrote:
> >
> > mmap in tidspbridge is missing range-checks. For now, make this
> > interface root-only, so that it does not cause security problems.
>
> Please fix this properly and don't paper
On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek wrote:
>
> mmap in tidspbridge is missing range-checks. For now, make this
> interface root-only, so that it does not cause security problems.
Please fix this properly and don't paper over the real problem here.
thanks,
greg k-h
--
To
mmap in tidspbridge is missing range-checks. For now, make this
interface root-only, so that it does not cause security problems.
Signed-off-by: Pavel Machek
Reported-by: Nico Golde
Reported-by: Fabian Yamaguchi
---
On Sat 2013-11-30 22:49:35, Dan Carpenter wrote:
> On Sat, Nov 30, 2013 at
mmap in tidspbridge is missing range-checks. For now, make this
interface root-only, so that it does not cause security problems.
Signed-off-by: Pavel Machek pa...@ucw.cz
Reported-by: Nico Golde n...@ngolde.de
Reported-by: Fabian Yamaguchi f...@goesec.de
---
On Sat 2013-11-30 22:49:35, Dan
On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek wrote:
mmap in tidspbridge is missing range-checks. For now, make this
interface root-only, so that it does not cause security problems.
Please fix this properly and don't paper over the real problem here.
thanks,
greg k-h
--
To
On Sat 2013-11-30 14:05:53, Greg KH wrote:
On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek wrote:
mmap in tidspbridge is missing range-checks. For now, make this
interface root-only, so that it does not cause security problems.
Please fix this properly and don't paper over the
On Sat, Nov 30, 2013 at 11:58:23PM +0100, Pavel Machek wrote:
On Sat 2013-11-30 14:05:53, Greg KH wrote:
On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek wrote:
mmap in tidspbridge is missing range-checks. For now, make this
interface root-only, so that it does not cause
28 matches
Mail list logo
