Re: [patch] block-dev: checking for NULL instead of IS_ERR()

2016-03-15 Thread Christoph Hellwig
On Tue, Mar 08, 2016 at 03:05:46PM +0300, Dan Carpenter wrote: > This should be an IS_ERR() check. mount_pseudo() returns error pointers > and this function should return the error pointer to its caller as well. > > Fixes: 3684aa7099e0 ('block-dev: enable writeback cgroup support') > Signed-off-b

[patch] block-dev: checking for NULL instead of IS_ERR()

2016-03-08 Thread Dan Carpenter
This should be an IS_ERR() check. mount_pseudo() returns error pointers and this function should return the error pointer to its caller as well. Fixes: 3684aa7099e0 ('block-dev: enable writeback cgroup support') Signed-off-by: Dan Carpenter diff --git a/fs/block_dev.c b/fs/block_dev.c index 317