On Mon, Jun 16, 2014 at 11:27:36AM -0700, Joe Perches wrote:
> > > Likely the \\[a-zA-Z] check should include
> > > all the tests that the multiple line string exceptions use.
> > >
> > > (?:\\(?:[ntr]|[0-7]{1,3}|x[0-9a-fA-F]{1,2})|;\s*|\{\s*)"\s*$
> >
> > That kind of complicate regex hurts my h
On Mon, 2014-06-16 at 09:40 +0300, Dan Carpenter wrote:
> On Fri, Jun 13, 2014 at 12:52:25PM -0700, Joe Perches wrote:
> > On Fri, 2014-06-13 at 12:46 +0300, Dan Carpenter wrote:
> > > On Fri, Jun 13, 2014 at 02:30:22AM -0700, Joe Perches wrote:
> > >
> > > > > +# check for missing a space in a st
On Fri, Jun 13, 2014 at 12:52:25PM -0700, Joe Perches wrote:
> On Fri, 2014-06-13 at 12:46 +0300, Dan Carpenter wrote:
> > On Fri, Jun 13, 2014 at 02:30:22AM -0700, Joe Perches wrote:
> >
> > > > +# check for missing a space in a string concatination
> > > > +if ($prevrawline =~ /[^\\][a-z
On Fri, 2014-06-13 at 12:46 +0300, Dan Carpenter wrote:
> On Fri, Jun 13, 2014 at 02:30:22AM -0700, Joe Perches wrote:
>
> > > +# check for missing a space in a string concatination
> > > +if ($prevrawline =~ /[^\\][a-zA-Z]"$/ && $rawline =~ /^\+[\t
> > > ]+"[a-zA-Z]/) {
> > > +
On Fri, Jun 13, 2014 at 02:30:22AM -0700, Joe Perches wrote:
> > +# check for missing a space in a string concatination
> > +if ($prevrawline =~ /[^\\][a-zA-Z]"$/ && $rawline =~ /^\+[\t
> > ]+"[a-zA-Z]/) {
> > +WARN('MISSING_SPACE',
> > + "break quoted strings
On Fri, 2014-06-13 at 09:53 +0300, Dan Carpenter wrote:
> Checkpatch already complains when people break up quoted strings but
> it's still pretty common. One mistake that people often make is they
> leave out the space character between the two strings.
>
> This check adds 453 new warnings. The
Checkpatch already complains when people break up quoted strings but
it's still pretty common. One mistake that people often make is they
leave out the space character between the two strings.
This check adds 453 new warnings. There very few false positives, here
is what they look like:
1) Most
7 matches
Mail list logo
