Re: [patch] checkpatch.pl: revert wrong --file message

2008-02-18 Thread Andi Kleen
> People, who do cleanups - I'm not talking about running lindent here - > read through the code while they fix it up. Please feel free to repeat my little experiment: give someone who sends you a lot of checkpatch.pl only patches a simple task that actually requires a little actual code change a

Re: [patch] checkpatch.pl: revert wrong --file message

2008-02-18 Thread Andi Kleen
On Saturday 16 February 2008 11:27:33 Pekka Enberg wrote: > Hi, > > On Feb 16, 2008 12:18 PM, Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > People, who do cleanups - I'm not talking about running lindent here - > > read through the code while they fix it up. > > > > Actually they find bugs that w

Re: [patch] checkpatch.pl: revert wrong --file message

2008-02-16 Thread Thomas Gleixner
On Sat, 16 Feb 2008, Andy Whitcroft wrote: > On Sat, Feb 16, 2008 at 12:27:33PM +0200, Pekka Enberg wrote: > > Hi, > > > > On Feb 16, 2008 12:18 PM, Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > > People, who do cleanups - I'm not talking about running lindent here - > > > read through the code w

Re: [patch] checkpatch.pl: revert wrong --file message

2008-02-16 Thread Andy Whitcroft
On Sat, Feb 16, 2008 at 12:27:33PM +0200, Pekka Enberg wrote: > Hi, > > On Feb 16, 2008 12:18 PM, Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > People, who do cleanups - I'm not talking about running lindent here - > > read through the code while they fix it up. > > > > Actually they find bugs th

Re: [patch] checkpatch.pl: revert wrong --file message

2008-02-16 Thread Cyrill Gorcunov
[Pekka Enberg - Sat, Feb 16, 2008 at 12:27:33PM +0200] | Hi, | | On Feb 16, 2008 12:18 PM, Thomas Gleixner <[EMAIL PROTECTED]> wrote: | > People, who do cleanups - I'm not talking about running lindent here - | > read through the code while they fix it up. | > | > Actually they find bugs that way

Re: [patch] checkpatch.pl: revert wrong --file message

2008-02-16 Thread Pekka Enberg
Hi, On Feb 16, 2008 12:18 PM, Thomas Gleixner <[EMAIL PROTECTED]> wrote: > People, who do cleanups - I'm not talking about running lindent here - > read through the code while they fix it up. > > Actually they find bugs that way or at least come up with useful > questions about code which is not o

Re: [patch] checkpatch.pl: revert wrong --file message

2008-02-16 Thread Thomas Gleixner
On Fri, 15 Feb 2008, Andi Kleen wrote: > > In the past few months we frequently mentioned checkpatch.pl --file to > > arch/x86 newbies and it's been a great source of cleanup patches and it > > has become an integral part of our workflow. Newbies should start with > > small baby steps, with triv

Re: [patch] checkpatch.pl: revert wrong --file message

2008-02-15 Thread Andi Kleen
> > In the past few months we frequently mentioned checkpatch.pl --file to > arch/x86 newbies and it's been a great source of cleanup patches and it > has become an integral part of our workflow. Newbies should start with > small baby steps, with trivial patches, they should learn to write cle

[patch] checkpatch.pl: revert wrong --file message

2008-02-15 Thread Ingo Molnar
Revert the incorrect, 6-line "WARNING" message that "checkpatch.pl --file" started emitting since commit 13214adf738ab, which was merged yesterday: Andi Kleen (1): Introduce a warning when --file mode is used The message warns against sending "pure code style patches": $