Re: [patch] cpuset: fix crash when adding CPUs to an empty set

2015-01-28 Thread Mike Galbraith
On Wed, 2015-01-28 at 12:53 +0100, Peter Zijlstra wrote: > On Wed, Jan 28, 2015 at 12:24:52PM +0800, Zefan Li wrote: > > > sched: Fix crash if cpuset_cpumask_can_shrink() is passed an empty cpumask > > > > > > While creating an exclusive cpuset, we passed cpuset_cpumask_can_shrink() > > > an empt

Re: [patch] cpuset: fix crash when adding CPUs to an empty set

2015-01-28 Thread Peter Zijlstra
On Wed, Jan 28, 2015 at 12:24:52PM +0800, Zefan Li wrote: > > sched: Fix crash if cpuset_cpumask_can_shrink() is passed an empty cpumask > > > > While creating an exclusive cpuset, we passed cpuset_cpumask_can_shrink() > > an empty cpumask (cur), and dl_bw_of(cpumask_any(cur)) made boom with it. >

Re: [patch] cpuset: fix crash when adding CPUs to an empty set

2015-01-27 Thread Zefan Li
Cc: Ingo Cc: Juri On 2015/1/28 11:53, Mike Galbraith wrote: > On Wed, 2015-01-28 at 10:41 +0800, Zefan Li wrote: > >>> --- >>> kernel/cpuset.c |2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> --- a/kernel/cpuset.c >>> +++ b/kernel/cpuset.c >>> @@ -511,7 +511,7 @@ static int v

Re: [patch] cpuset: fix crash when adding CPUs to an empty set

2015-01-27 Thread Mike Galbraith
On Wed, 2015-01-28 at 10:41 +0800, Zefan Li wrote: > > --- > > kernel/cpuset.c |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- a/kernel/cpuset.c > > +++ b/kernel/cpuset.c > > @@ -511,7 +511,7 @@ static int validate_change(struct cpuset > > * tasks. > > */ > >

Re: [patch] cpuset: fix crash when adding CPUs to an empty set

2015-01-27 Thread Zefan Li
Hi Mike, On 2015/1/21 14:16, Mike Galbraith wrote: > > While creating a set of shielded CPUs, we passed cpuset_cpumask_can_shrink() > an empty cpumask (cur), and dl_bw_of(cpumask_any(cur)) made boom with it. > > [ 514.513841] CPU: 0 PID: 6942 Comm: shield.sh Not tainted 3.19.0-master #19 > [ 5

[patch] cpuset: fix crash when adding CPUs to an empty set

2015-01-20 Thread Mike Galbraith
While creating a set of shielded CPUs, we passed cpuset_cpumask_can_shrink() an empty cpumask (cur), and dl_bw_of(cpumask_any(cur)) made boom with it. [ 514.513841] CPU: 0 PID: 6942 Comm: shield.sh Not tainted 3.19.0-master #19 [ 514.513841] Hardware name: MEDIONPC MS-7502/MS-7502, BIOS 6.00 PG