Re: [patch] drivers/ide/pci/alim15x3.c SMP fix

2005-09-01 Thread Alan Cox
On Iau, 2005-09-01 at 09:24 +0200, Ingo Molnar wrote: > is this the right way to fix the UP assumption below? Probably not. The ide_lock may already be held (randomly depending on the code path) at the point we retune a drive on error. Actually you probably crash before this anyway. The ALi code

Re: [patch] drivers/ide/pci/alim15x3.c SMP fix

2005-09-01 Thread Rui Nuno Capela
Ingo Molnar wrote: Rui Nuno Capela wrote: OK. The reported boot WARNING seems to be over now. Tested on the offended laptop ([EMAIL PROTECTED]/UP, PCI chipset: ALi M1533) with 2.6.13-rt3, where the suggested patch on drivers/ide/pci/alim15x3.c seems to fix the burp. All seems to be working fin

Re: [patch] drivers/ide/pci/alim15x3.c SMP fix

2005-09-01 Thread Ingo Molnar
* Rui Nuno Capela <[EMAIL PROTECTED]> wrote: > Ingo Molnar wrote: > >is this the right way to fix the UP assumption below? > > > > Ingo > > > >Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> > > > >Index: linux/drivers/ide/pci/alim15x3.c > > [snip] > > OK. The reported boot WARNING seems to b

Re: [patch] drivers/ide/pci/alim15x3.c SMP fix

2005-09-01 Thread Rui Nuno Capela
Ingo Molnar wrote: is this the right way to fix the UP assumption below? Ingo Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Index: linux/drivers/ide/pci/alim15x3.c > [snip] OK. The reported boot WARNING seems to be over now. Tested on the offended laptop ([EMAIL PROTECTED]/UP, PCI

[patch] drivers/ide/pci/alim15x3.c SMP fix

2005-09-01 Thread Ingo Molnar
is this the right way to fix the UP assumption below? Ingo Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Index: linux/drivers/ide/pci/alim15x3.c === --- linux.orig/drivers/ide/pci/alim15x3.c +++ linux/drivers/ide/pci/alim1