Re: [patch] fix ucb1x00 support on collie

2005-08-12 Thread Russell King
On Fri, Aug 12, 2005 at 01:11:03PM +0200, Pavel Machek wrote: > You still do: > > Ser4MCCR0 = data->mccr0 | 0x7f7f; > > ...I'm not sure, but it seems to me I want MMCR0 to be set to > 0x6. Would it be better to move 7f7f constant (what is it, anyway) > to machine-specific code? I do this

Re: [patch] fix ucb1x00 support on collie

2005-08-12 Thread Pavel Machek
Hi! > > > > > diff --git a/drivers/misc/mcp-sa1100.c b/drivers/misc/mcp-sa1100.c > > > --- a/drivers/misc/mcp-sa1100.c > > > +++ b/drivers/misc/mcp-sa1100.c > > > @@ -149,7 +149,7 @@ static int mcp_sa1100_probe(struct devic > > > !machine_is_graphicsmaster() && !machine_is_lart()

Re: [patch] fix ucb1x00 support on collie

2005-08-12 Thread Pavel Machek
Hi! diff --git a/drivers/misc/mcp-sa1100.c b/drivers/misc/mcp-sa1100.c --- a/drivers/misc/mcp-sa1100.c +++ b/drivers/misc/mcp-sa1100.c @@ -149,7 +149,7 @@ static int mcp_sa1100_probe(struct devic !machine_is_graphicsmaster() !machine_is_lart()

Re: [patch] fix ucb1x00 support on collie

2005-08-12 Thread Russell King
On Fri, Aug 12, 2005 at 01:11:03PM +0200, Pavel Machek wrote: You still do: Ser4MCCR0 = data-mccr0 | 0x7f7f; ...I'm not sure, but it seems to me I want MMCR0 to be set to 0x6. Would it be better to move 7f7f constant (what is it, anyway) to machine-specific code? I do this because we

Re: [patch] fix ucb1x00 support on collie

2005-08-07 Thread Russell King
On Sun, Jul 31, 2005 at 04:42:45PM +0100, Russell King wrote: > On Sun, Jul 31, 2005 at 03:46:17PM +0200, Pavel Machek wrote: > > Collie is slightly strange; it does not seem to have proper ucb1x00 > > ID. With this patch, basic ucb support seems to work and I can get > > interrupts from battery.

Re: [patch] fix ucb1x00 support on collie

2005-08-07 Thread Russell King
On Sun, Jul 31, 2005 at 04:42:45PM +0100, Russell King wrote: On Sun, Jul 31, 2005 at 03:46:17PM +0200, Pavel Machek wrote: Collie is slightly strange; it does not seem to have proper ucb1x00 ID. With this patch, basic ucb support seems to work and I can get interrupts from battery. Out

Re: [patch] fix ucb1x00 support on collie

2005-07-31 Thread Russell King
On Sun, Jul 31, 2005 at 03:46:17PM +0200, Pavel Machek wrote: > Collie is slightly strange; it does not seem to have proper ucb1x00 > ID. With this patch, basic ucb support seems to work and I can get > interrupts from battery. Out of interest, what ID does it appear to have? > diff --git

[patch] fix ucb1x00 support on collie

2005-07-31 Thread Pavel Machek
Collie is slightly strange; it does not seem to have proper ucb1x00 ID. With this patch, basic ucb support seems to work and I can get interrupts from battery. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> --- commit 7247714847e6e3eebcdd71c58a4f730e12f0e56b tree

[patch] fix ucb1x00 support on collie

2005-07-31 Thread Pavel Machek
Collie is slightly strange; it does not seem to have proper ucb1x00 ID. With this patch, basic ucb support seems to work and I can get interrupts from battery. Signed-off-by: Pavel Machek [EMAIL PROTECTED] --- commit 7247714847e6e3eebcdd71c58a4f730e12f0e56b tree

Re: [patch] fix ucb1x00 support on collie

2005-07-31 Thread Russell King
On Sun, Jul 31, 2005 at 03:46:17PM +0200, Pavel Machek wrote: Collie is slightly strange; it does not seem to have proper ucb1x00 ID. With this patch, basic ucb support seems to work and I can get interrupts from battery. Out of interest, what ID does it appear to have? diff --git