Re: [linux-usb-devel] [patch] hotplug fixes

2000-12-10 Thread David Brownell
> - We have been getting deadlocks at hotplug time because > call_usermodehelper is synchronous: it returns control after the > usermode application has exited. But in some places (esp. > [un]register_netdevice) this happens with a lock held (rtnl_lock). > This cause `ifconfig' to get s

Re: [patch] hotplug fixes

2000-12-10 Thread David Woodhouse
On Sun, 10 Dec 2000, Linus Torvalds wrote: > All user-mode-helpers are async as of this patch. > > The reason for the serialization is that we need to wait until the exec() > has taken place - so that the arguments that the caller set up haven't > disappeared from the caller stack. The actual exe

Re: [patch] hotplug fixes

2000-12-10 Thread Linus Torvalds
On Sun, 10 Dec 2000, David Woodhouse wrote: > > That's sick. Do we have to? The PCMCIA coded obviously wants an async > call_usermodehelper() or it wouldn't have been using schedule_task() > for it in the first place, would it? Can't we pass an 'int async' arg to > call_usermodehelper() instead

Re: [patch] hotplug fixes

2000-12-10 Thread Andrew Morton
David Woodhouse wrote: > > On Sun, 10 Dec 2000, Andrew Morton wrote: > > > - PCMCIA layer calls call_usermodehelper from within keventd. But > > call_usermodehelper blocks until keventd has run the helper! Duh. > > > > This patch special-cases the situation where keventd is calling > > ca

Re: [patch] hotplug fixes

2000-12-10 Thread David Woodhouse
On Sun, 10 Dec 2000, Andrew Morton wrote: > - PCMCIA layer calls call_usermodehelper from within keventd. But > call_usermodehelper blocks until keventd has run the helper! Duh. > > This patch special-cases the situation where keventd is calling > call_usermodehelper(). + if (curren

[patch] hotplug fixes

2000-12-10 Thread Andrew Morton
This is a bunch of changes to the hotplug code, keventd, PCI, netdevices and call_usermodehelper(). It should fix a number of the PCMCIA problems people have been reporting. There are still some questions and issues over this stuff - I'll cover that in a separate email. - We have been getting

[patch] hotplug fixes Re: test11-pre6

2000-11-17 Thread Tigran Aivazian
On Thu, 16 Nov 2000, Linus Torvalds wrote: > > The log-file says it all.. > > Linus No, I am sorry but it does not mention hotplug things in net/core/dev.c and they are broken. The fix below. Regards, Tigran diff -urN -X dontdiff linux/init/main.c work/init/main.c --- linux/ini