Re: [patch] mfd: vexpress: use after free in vexpress_syscfg_regmap_init()

2014-06-11 Thread Dan Carpenter
On Wed, Jun 11, 2014 at 10:22:22AM +0100, Pawel Moll wrote: > On Wed, 2014-06-11 at 07:07 +0100, Dan Carpenter wrote: > > We should return NULL if regmap_init() fails instead of continuing. > > > > Signed-off-by: Dan Carpenter > > > > diff --git a/drivers/misc/vexpress-syscfg.c

Re: [patch] mfd: vexpress: use after free in vexpress_syscfg_regmap_init()

2014-06-11 Thread Pawel Moll
On Wed, 2014-06-11 at 07:07 +0100, Dan Carpenter wrote: > We should return NULL if regmap_init() fails instead of continuing. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/misc/vexpress-syscfg.c b/drivers/misc/vexpress-syscfg.c > index 73068e5..2c0ddb2 100644 > ---

[patch] mfd: vexpress: use after free in vexpress_syscfg_regmap_init()

2014-06-11 Thread Dan Carpenter
We should return NULL if regmap_init() fails instead of continuing. Signed-off-by: Dan Carpenter diff --git a/drivers/misc/vexpress-syscfg.c b/drivers/misc/vexpress-syscfg.c index 73068e5..2c0ddb2 100644 --- a/drivers/misc/vexpress-syscfg.c +++ b/drivers/misc/vexpress-syscfg.c @@ -231,10

[patch] mfd: vexpress: use after free in vexpress_syscfg_regmap_init()

2014-06-11 Thread Dan Carpenter
We should return NULL if regmap_init() fails instead of continuing. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/misc/vexpress-syscfg.c b/drivers/misc/vexpress-syscfg.c index 73068e5..2c0ddb2 100644 --- a/drivers/misc/vexpress-syscfg.c +++

Re: [patch] mfd: vexpress: use after free in vexpress_syscfg_regmap_init()

2014-06-11 Thread Pawel Moll
On Wed, 2014-06-11 at 07:07 +0100, Dan Carpenter wrote: We should return NULL if regmap_init() fails instead of continuing. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/misc/vexpress-syscfg.c b/drivers/misc/vexpress-syscfg.c index 73068e5..2c0ddb2 100644 ---

Re: [patch] mfd: vexpress: use after free in vexpress_syscfg_regmap_init()

2014-06-11 Thread Dan Carpenter
On Wed, Jun 11, 2014 at 10:22:22AM +0100, Pawel Moll wrote: On Wed, 2014-06-11 at 07:07 +0100, Dan Carpenter wrote: We should return NULL if regmap_init() fails instead of continuing. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/misc/vexpress-syscfg.c