Re: [patch] mm, memcg: periodically schedule when emptying page list

2014-06-02 Thread Hugh Dickins
On Mon, 2 Jun 2014, David Rientjes wrote: > On Mon, 2 Jun 2014, Hugh Dickins wrote: > > > Why not just move that cond_resched() down below the if/else? > > No need to test need_resched() separately, and this page is not busy. > > > > Would you like to propose your version from our kernel instead

Re: [patch] mm, memcg: periodically schedule when emptying page list

2014-06-02 Thread David Rientjes
On Mon, 2 Jun 2014, Hugh Dickins wrote: > Why not just move that cond_resched() down below the if/else? > No need to test need_resched() separately, and this page is not busy. > Would you like to propose your version from our kernel instead? -- To unsubscribe from this list: send the line "unsub

Re: [patch] mm, memcg: periodically schedule when emptying page list

2014-06-02 Thread Hugh Dickins
On Mon, 2 Jun 2014, David Rientjes wrote: > mem_cgroup_force_empty_list() can iterate a large number of pages on an lru > and > mem_cgroup_move_parent() doesn't return an errno unless certain criteria, > none > of which indicate that the iteration may be taking too long, is met. > > We have e

[patch] mm, memcg: periodically schedule when emptying page list

2014-06-02 Thread David Rientjes
mem_cgroup_force_empty_list() can iterate a large number of pages on an lru and mem_cgroup_move_parent() doesn't return an errno unless certain criteria, none of which indicate that the iteration may be taking too long, is met. We have encountered the following stack trace many times indicating