Re: [patch] mm: memcontrol: fold mem_cgroup_start_move()/mem_cgroup_end_move()

2014-10-23 Thread Johannes Weiner
On Thu, Oct 23, 2014 at 05:56:07PM +0200, Michal Hocko wrote: > On Thu 23-10-14 10:42:07, Johannes Weiner wrote: > > Having these functions and their documentation split out and somewhere > > makes it harder, not easier, to follow what's going on. > > > > Inline them directly where charge moving i

Re: [patch] mm: memcontrol: fold mem_cgroup_start_move()/mem_cgroup_end_move()

2014-10-23 Thread Michal Hocko
On Thu 23-10-14 10:42:07, Johannes Weiner wrote: > Having these functions and their documentation split out and somewhere > makes it harder, not easier, to follow what's going on. > > Inline them directly where charge moving is prepared and finished, and > put an explanation right next to it. I d

[patch] mm: memcontrol: fold mem_cgroup_start_move()/mem_cgroup_end_move()

2014-10-23 Thread Johannes Weiner
Having these functions and their documentation split out and somewhere makes it harder, not easier, to follow what's going on. Inline them directly where charge moving is prepared and finished, and put an explanation right next to it. Signed-off-by: Johannes Weiner --- mm/memcontrol.c | 40