Re: [patch] mousedev.c

2000-09-22 Thread Igmar Palsenberg
On Fri, 22 Sep 2000, Russell King wrote: > You're telling us that: > > if (list->mode > 1) { > index = 4; > break; > } > > is the same as: > > if (list->mode > 1) > index = 4; > break; No, it isn't.. Ws confused with switch() {

Re: [patch] mousedev.c

2000-09-22 Thread Russell King
Igmar Palsenberg writes: > Patch looks not necessary. The compiler executes the statements until it > encounters a break. > > > - case BTN_EXTRA: if (list->mode > 1) { index = 4; break; } > > + case BTN_EXTRA: if (list->mode > 1) index = 4; break; You're telling us that: if (list->m

Re: [patch] mousedev.c

2000-09-21 Thread Peter Samuelson
[Igmar Palsenberg] > Patch looks not necessary. The compiler executes the statements until it > encounters a break. > > > - case BTN_EXTRA: if (list->mode > 1) { index = 4; break; } > > + case BTN_EXTRA: if (list->mode > 1) index = 4; break; ^^^ You

Re: [patch] mousedev.c

2000-09-21 Thread Igmar Palsenberg
Hi, Patch looks not necessary. The compiler executes the statements until it encounters a break. > - case BTN_EXTRA: if (list->mode > 1) >{ index = 4; break; } > + case BTN_EXTRA: if (list->mode > 1)

Re: [patch] mousedev.c

2000-09-21 Thread Vojtech Pavlik
On Fri, Sep 22, 2000 at 12:03:20AM +0900, Yoichi Imai wrote: > I think it's a bug. I think it's a feature. > --- linux-2.4.0-test8/drivers/input/mousedev.c Wed Aug 23 01:06:31 2000 > +++ linux/drivers/input/mousedev.c Thu Sep 21 22:20:22 2000 > @@ -121,12 +121,12 @@ >

[patch] mousedev.c

2000-09-21 Thread Yoichi Imai
Hello. I think it's a bug. --- linux-2.4.0-test8/drivers/input/mousedev.c Wed Aug 23 01:06:31 2000 +++ linux/drivers/input/mousedev.c Thu Sep 21 22:20:22 2000 @@ -121,12 +121,12 @@ case BTN_TOUCH: