Re: [patch] preempt: select PREEMPT_DYNAMIC under PREEMPTION instead of PREEMPT

2021-02-09 Thread Mike Galbraith
On Tue, 2021-02-09 at 17:19 +0100, Peter Zijlstra wrote: > On Tue, Feb 09, 2021 at 05:13:15PM +0100, Peter Zijlstra wrote: > > On Tue, Feb 09, 2021 at 05:05:14PM +0100, Mike Galbraith wrote: > > > > > ld: init/main.o: in function `trace_initcall_start': > > > /backup/usr/local/src/kernel/linux-tip-

Re: [patch] preempt: select PREEMPT_DYNAMIC under PREEMPTION instead of PREEMPT

2021-02-09 Thread Mike Galbraith
On Tue, 2021-02-09 at 17:13 +0100, Peter Zijlstra wrote: > On Tue, Feb 09, 2021 at 05:05:14PM +0100, Mike Galbraith wrote: > > > ld: init/main.o: in function `trace_initcall_start': > > /backup/usr/local/src/kernel/linux-tip-rt/./include/trace/events/initcall.h:27: > > undefined reference to `__SC

Re: [patch] preempt: select PREEMPT_DYNAMIC under PREEMPTION instead of PREEMPT

2021-02-09 Thread Peter Zijlstra
On Tue, Feb 09, 2021 at 05:13:15PM +0100, Peter Zijlstra wrote: > On Tue, Feb 09, 2021 at 05:05:14PM +0100, Mike Galbraith wrote: > > > ld: init/main.o: in function `trace_initcall_start': > > /backup/usr/local/src/kernel/linux-tip-rt/./include/trace/events/initcall.h:27: > > undefined reference

Re: [patch] preempt: select PREEMPT_DYNAMIC under PREEMPTION instead of PREEMPT

2021-02-09 Thread Peter Zijlstra
On Tue, Feb 09, 2021 at 05:05:14PM +0100, Mike Galbraith wrote: > ld: init/main.o: in function `trace_initcall_start': > /backup/usr/local/src/kernel/linux-tip-rt/./include/trace/events/initcall.h:27: > undefined reference to `__SCT__preempt_schedule_notrace' Ooohh... this is because x86 can't b

Re: [patch] preempt: select PREEMPT_DYNAMIC under PREEMPTION instead of PREEMPT

2021-02-09 Thread Mike Galbraith
On Tue, 2021-02-09 at 16:13 +0100, Peter Zijlstra wrote: > On Tue, Feb 09, 2021 at 02:45:37PM +0100, Mike Galbraith wrote: > > > > PREEMPT_RT and PREEMPT both needs PREEMPT_DYNAMIC to build, so move > > selection of PREEMPT_DYNAMIC to the common denominator, PREEMPTION. > > I'm confused, why would

Re: [patch] preempt: select PREEMPT_DYNAMIC under PREEMPTION instead of PREEMPT

2021-02-09 Thread Peter Zijlstra
On Tue, Feb 09, 2021 at 02:45:37PM +0100, Mike Galbraith wrote: > > PREEMPT_RT and PREEMPT both needs PREEMPT_DYNAMIC to build, so move > selection of PREEMPT_DYNAMIC to the common denominator, PREEMPTION. I'm confused, why would you want PREEMPT_DYNAMIC for PREEMPT_RT ? PREEMPT_RT without full

[patch] preempt: select PREEMPT_DYNAMIC under PREEMPTION instead of PREEMPT

2021-02-09 Thread Mike Galbraith
PREEMPT_RT and PREEMPT both needs PREEMPT_DYNAMIC to build, so move selection of PREEMPT_DYNAMIC to the common denominator, PREEMPTION. Signed-off-by: Mike Galbraith --- kernel/Kconfig.preempt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/kernel/Kconfig.preempt +++ b/kernel/K