Re: [patch] printk: add KERN_CONT annotation

2007-10-04 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > On Tue, 2 Oct 2007 07:18:52 +0200 > Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > printk: add the KERN_CONT annotation (which is empty string but via > > which checkpatch.pl can notice that the lacking KERN_ level is fine). > > This useful for m

Re: [patch] printk: add KERN_CONT annotation

2007-10-04 Thread Andrew Morton
On Tue, 2 Oct 2007 07:18:52 +0200 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > printk: add the KERN_CONT annotation (which is empty string but via > which checkpatch.pl can notice that the lacking KERN_ level is fine). > This useful for multiple calls of hand-crafted printk output done by > earl

Re: [patch] printk: add KERN_CONT annotation

2007-10-02 Thread Joe Perches
On Tue, 2007-10-02 at 17:45 +0200, Jan Engelhardt wrote: > always use printk("%s", var) You have to use indirect arguments to log something? Don't you think that's a stupid rule? Look at the version strings that are used as __devinitdata. - To unsubscribe from this list: send the line "unsubscr

Re: [patch] printk: add KERN_CONT annotation

2007-10-02 Thread Jan Engelhardt
On Oct 2 2007 09:03, Joe Perches wrote: >On Tue, 2007-10-02 at 17:45 +0200, Jan Engelhardt wrote: >> always use printk("%s", var) > >You have to use indirect arguments to log something? No, you do not have to. >Don't you think that's a stupid rule? Not at all. var may contain format specifiers,

Re: [patch] printk: add KERN_CONT annotation

2007-10-02 Thread Jan Engelhardt
On Oct 2 2007 08:41, Joe Perches wrote: >On Tue, 2007-10-02 at 07:18 +0200, Ingo Molnar wrote: >> +#define KERN_CONT "" > >This doesn't work with printk(char** array[index]) continuations >or with strings with embedded KERN_ prefixes. Huh? ...Ah. Yeah, pasting a string literal with a va

Re: [patch] printk: add KERN_CONT annotation

2007-10-02 Thread Joe Perches
On Tue, 2007-10-02 at 07:18 +0200, Ingo Molnar wrote: > +#define KERN_CONT "" This doesn't work with printk(char** array[index]) continuations or with strings with embedded KERN_ prefixes. printk(array[index]) printk(version) - To unsubscribe from this list: send the line "unsubscrib

Re: [patch] printk: add KERN_CONT annotation

2007-10-02 Thread Jörn Engel
On Tue, 2 October 2007 07:18:52 +0200, Ingo Molnar wrote: > > ah, this is even nicer than the raw_printk() thing i suggested, and it > also nicely documents the intention of the author. Patch attached below. KERN_CONT was brought up in the linux-tiny discussion. Not sure if you want to get invo

[patch] printk: add KERN_CONT annotation

2007-10-01 Thread Ingo Molnar
* Willy Tarreau <[EMAIL PROTECTED]> wrote: > Well, I think that we could do something like this : > > #define KERN_CONT "" > ... > printk(KERN_ERR "foo"); > <100 lines of whatever> > printk(KERN_CONT "bar\n"); > > It would indicate the author's *intent* which is to continue a