Re: [patch] sbp-target: checking for NULL instead of IS_ERR

2016-03-10 Thread Nicholas A. Bellinger
On Thu, 2016-03-10 at 22:58 +, Chris Boot wrote: > On 10/03/16 21:52, Chris Boot wrote: > > On 10/03/16 20:56, Chris Boot wrote: > >> On 05/03/16 09:33, Nicholas A. Bellinger wrote: > >>> On Sat, 2016-03-05 at 08:45 +, Chris Boot wrote: > Are these in linux-next or another branch somew

Re: [patch] sbp-target: checking for NULL instead of IS_ERR

2016-03-10 Thread Chris Boot
On 10/03/16 21:52, Chris Boot wrote: > On 10/03/16 20:56, Chris Boot wrote: >> On 05/03/16 09:33, Nicholas A. Bellinger wrote: >>> On Sat, 2016-03-05 at 08:45 +, Chris Boot wrote: Are these in linux-next or another branch somewhere I can easily clone them from? >>> >>> The patch serie

Re: [patch] sbp-target: checking for NULL instead of IS_ERR

2016-03-10 Thread Chris Boot
On 10/03/16 20:56, Chris Boot wrote: > On 05/03/16 09:33, Nicholas A. Bellinger wrote: >> On Sat, 2016-03-05 at 08:45 +, Chris Boot wrote: >>> Are these in linux-next or another branch somewhere I can easily clone >>> them from? >> >> The patch series is in target-pending/for-next. > > Hi Nic,

Re: [patch] sbp-target: checking for NULL instead of IS_ERR

2016-03-10 Thread Chris Boot
On 05/03/16 09:33, Nicholas A. Bellinger wrote: > On Sat, 2016-03-05 at 08:45 +, Chris Boot wrote: >> Are these in linux-next or another branch somewhere I can easily clone >> them from? > > The patch series is in target-pending/for-next. Hi Nic, I've just managed to resurrect a test rig for

Re: [patch] sbp-target: checking for NULL instead of IS_ERR

2016-03-05 Thread Nicholas A. Bellinger
On Sat, 2016-03-05 at 08:45 +, Chris Boot wrote: > On 5 Mar 2016, at 07:33, Nicholas A. Bellinger wrote: > > > > Hi Dan + BootC, > > > > On Wed, 2016-03-02 at 13:09 +0300, Dan Carpenter wrote: > >> We changed this from kzalloc to sbp_mgt_get_req() so we need to change > >> from checking for

Re: [patch] sbp-target: checking for NULL instead of IS_ERR

2016-03-05 Thread Chris Boot
On 5 Mar 2016, at 07:33, Nicholas A. Bellinger wrote: > > Hi Dan + BootC, > > On Wed, 2016-03-02 at 13:09 +0300, Dan Carpenter wrote: >> We changed this from kzalloc to sbp_mgt_get_req() so we need to change >> from checking for NULL to check for error pointers. >> >> Fixes: c064b2a78989 ('sbp-

Re: [patch] sbp-target: checking for NULL instead of IS_ERR

2016-03-04 Thread Nicholas A. Bellinger
Hi Dan + BootC, On Wed, 2016-03-02 at 13:09 +0300, Dan Carpenter wrote: > We changed this from kzalloc to sbp_mgt_get_req() so we need to change > from checking for NULL to check for error pointers. > > Fixes: c064b2a78989 ('sbp-target: Conversion to percpu_ida tag > pre-allocation') > Signed-of

[patch] sbp-target: checking for NULL instead of IS_ERR

2016-03-02 Thread Dan Carpenter
We changed this from kzalloc to sbp_mgt_get_req() so we need to change from checking for NULL to check for error pointers. Fixes: c064b2a78989 ('sbp-target: Conversion to percpu_ida tag pre-allocation') Signed-off-by: Dan Carpenter diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sb