Re: [patch] sched: fix active load balance

2005-04-14 Thread Ingo Molnar
* Siddha, Suresh B <[EMAIL PROTECTED]> wrote: > Your suggestion also looks similar to my patch. You are also breaking > on the first one. yeah. > We want the first domain spanning both the cpu's. That is the domain > where normal load balance failed and we restore to active load > balance.

Re: [patch] sched: fix active load balance

2005-04-13 Thread Nick Piggin
Siddha, Suresh B wrote: On Wed, Apr 13, 2005 at 10:08:28PM +0200, Ingo Molnar wrote: * Siddha, Suresh B <[EMAIL PROTECTED]> wrote: - for_each_domain(target_cpu, sd) { + for_each_domain(target_cpu, sd) if ((sd->flags & SD_LOAD_BALANCE) && - cpu_isse

Re: [patch] sched: fix active load balance

2005-04-13 Thread Siddha, Suresh B
On Wed, Apr 13, 2005 at 10:08:28PM +0200, Ingo Molnar wrote: > > * Siddha, Suresh B <[EMAIL PROTECTED]> wrote: > > > - for_each_domain(target_cpu, sd) { > > + for_each_domain(target_cpu, sd) > > if ((sd->flags & SD_LOAD_BALANCE) && > > - cpu_isset(busiest_cpu, sd

Re: [patch] sched: fix active load balance

2005-04-13 Thread Ingo Molnar
* Siddha, Suresh B <[EMAIL PROTECTED]> wrote: > - for_each_domain(target_cpu, sd) { > + for_each_domain(target_cpu, sd) > if ((sd->flags & SD_LOAD_BALANCE) && > - cpu_isset(busiest_cpu, sd->span)) { > - sd = tmp; > +

[patch] sched: fix active load balance

2005-04-13 Thread Siddha, Suresh B
Recent changes to active load balance (sched2-fix-smt-scheduling-problems.patch in -mm) is not resulting in any task movement from busiest to target_cpu. Attached patch(ontop of -mm) fixes this issue. Signed-off-by: Suresh Siddha <[EMAIL PROTECTED]> --- linux-2.6.12-rc2-mm3/kernel/sched.c 2005-04