Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Christoph Hellwig
On Mon, Jun 18, 2007 at 09:00:09PM +0200, Sam Ravnborg wrote: > Do you imply that if we see asm or __asm__ in user space headers we ougth > to warn about it? > Seems at least sensible to me but if we introduce such a check we should > kill all offenders first - which Mike's patches seems to

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Sam Ravnborg
On Mon, Jun 18, 2007 at 07:34:50PM +0100, Christoph Hellwig wrote: > On Sun, Jun 17, 2007 at 06:33:28PM -0400, Mike Frysinger wrote: > > This changes asm() to __asm__() and volatile to __volatile__ so that these > > headers can be used with gcc's -std=c99. > > We should not allow inline assemly

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Christoph Hellwig
On Mon, Jun 18, 2007 at 07:34:50PM +0100, Christoph Hellwig wrote: > On Sun, Jun 17, 2007 at 06:33:28PM -0400, Mike Frysinger wrote: > > This changes asm() to __asm__() and volatile to __volatile__ so that these > > headers can be used with gcc's -std=c99. > > We should not allow inline assemly

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Christoph Hellwig
On Sun, Jun 17, 2007 at 06:33:28PM -0400, Mike Frysinger wrote: > This changes asm() to __asm__() and volatile to __volatile__ so that these > headers can be used with gcc's -std=c99. We should not allow inline assemly in the exported part of userspace headers at all. These headers must only

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Mike Frysinger
On Monday 18 June 2007, Christoph Hellwig wrote: > On Mon, Jun 18, 2007 at 01:24:24AM +0200, Arnd Bergmann wrote: > > On Monday 18 June 2007, Arjan van de Ven wrote: > > > On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: > > > > This changes asm() to __asm__() and volatile to __volatile__

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Christoph Hellwig
On Mon, Jun 18, 2007 at 08:27:15AM -0600, Robert Hancock wrote: > If we expect userspace apps to include them, then I would vote for no, > not for anything outside of #ifdef __KERNEL__ in exported headers. Keep > in mind also that C++ apps may need to include these as well and those >

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Christoph Hellwig
On Mon, Jun 18, 2007 at 01:24:24AM +0200, Arnd Bergmann wrote: > On Monday 18 June 2007, Arjan van de Ven wrote: > > > > On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: > > > This changes asm() to __asm__() and volatile to __volatile__ so that these > > > headers can be used with gcc's

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread H. Peter Anvin
Robert Hancock wrote: > > If we expect userspace apps to include them, then I would vote for no, > not for anything outside of #ifdef __KERNEL__ in exported headers. Keep > in mind also that C++ apps may need to include these as well and those > extensions don't always play well in C++ mode.

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Robert Hancock
David Woodhouse wrote: On Mon, 2007-06-18 at 01:24 +0200, Arnd Bergmann wrote: On Monday 18 June 2007, Arjan van de Ven wrote: On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: This changes asm() to __asm__() and volatile to __volatile__ so that these headers can be used with gcc's

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread David Woodhouse
On Mon, 2007-06-18 at 01:24 +0200, Arnd Bergmann wrote: > On Monday 18 June 2007, Arjan van de Ven wrote: > > > > On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: > > > This changes asm() to __asm__() and volatile to __volatile__ so that these > > > headers can be used with gcc's

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread David Woodhouse
On Mon, 2007-06-18 at 01:24 +0200, Arnd Bergmann wrote: On Monday 18 June 2007, Arjan van de Ven wrote: On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: This changes asm() to __asm__() and volatile to __volatile__ so that these headers can be used with gcc's -std=c99. hmm

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Robert Hancock
David Woodhouse wrote: On Mon, 2007-06-18 at 01:24 +0200, Arnd Bergmann wrote: On Monday 18 June 2007, Arjan van de Ven wrote: On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: This changes asm() to __asm__() and volatile to __volatile__ so that these headers can be used with gcc's

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread H. Peter Anvin
Robert Hancock wrote: If we expect userspace apps to include them, then I would vote for no, not for anything outside of #ifdef __KERNEL__ in exported headers. Keep in mind also that C++ apps may need to include these as well and those extensions don't always play well in C++ mode. (Last

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Christoph Hellwig
On Mon, Jun 18, 2007 at 01:24:24AM +0200, Arnd Bergmann wrote: On Monday 18 June 2007, Arjan van de Ven wrote: On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: This changes asm() to __asm__() and volatile to __volatile__ so that these headers can be used with gcc's -std=c99.

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Christoph Hellwig
On Mon, Jun 18, 2007 at 08:27:15AM -0600, Robert Hancock wrote: If we expect userspace apps to include them, then I would vote for no, not for anything outside of #ifdef __KERNEL__ in exported headers. Keep in mind also that C++ apps may need to include these as well and those extensions

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Mike Frysinger
On Monday 18 June 2007, Christoph Hellwig wrote: On Mon, Jun 18, 2007 at 01:24:24AM +0200, Arnd Bergmann wrote: On Monday 18 June 2007, Arjan van de Ven wrote: On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: This changes asm() to __asm__() and volatile to __volatile__ so that

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Christoph Hellwig
On Sun, Jun 17, 2007 at 06:33:28PM -0400, Mike Frysinger wrote: This changes asm() to __asm__() and volatile to __volatile__ so that these headers can be used with gcc's -std=c99. We should not allow inline assemly in the exported part of userspace headers at all. These headers must only

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Christoph Hellwig
On Mon, Jun 18, 2007 at 07:34:50PM +0100, Christoph Hellwig wrote: On Sun, Jun 17, 2007 at 06:33:28PM -0400, Mike Frysinger wrote: This changes asm() to __asm__() and volatile to __volatile__ so that these headers can be used with gcc's -std=c99. We should not allow inline assemly in the

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Sam Ravnborg
On Mon, Jun 18, 2007 at 07:34:50PM +0100, Christoph Hellwig wrote: On Sun, Jun 17, 2007 at 06:33:28PM -0400, Mike Frysinger wrote: This changes asm() to __asm__() and volatile to __volatile__ so that these headers can be used with gcc's -std=c99. We should not allow inline assemly in the

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-18 Thread Christoph Hellwig
On Mon, Jun 18, 2007 at 09:00:09PM +0200, Sam Ravnborg wrote: Do you imply that if we see asm or __asm__ in user space headers we ougth to warn about it? Seems at least sensible to me but if we introduce such a check we should kill all offenders first - which Mike's patches seems to trigger

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-17 Thread Mike Frysinger
On Sunday 17 June 2007, Arnd Bergmann wrote: > On Monday 18 June 2007, Arjan van de Ven wrote: > > On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: > > > This changes asm() to __asm__() and volatile to __volatile__ so that > > > these headers can be used with gcc's -std=c99. > > > > hmm

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-17 Thread Arnd Bergmann
On Monday 18 June 2007, Arjan van de Ven wrote: > > On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: > > This changes asm() to __asm__() and volatile to __volatile__ so that these > > headers can be used with gcc's -std=c99. > > hmm but the kernel doesn't use -std=c99... The byteorder

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-17 Thread Arjan van de Ven
On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: > This changes asm() to __asm__() and volatile to __volatile__ so that these > headers can be used with gcc's -std=c99. hmm but the kernel doesn't use -std=c99... - To unsubscribe from this list: send the line "unsubscribe linux-kernel"

[patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-17 Thread Mike Frysinger
This changes asm() to __asm__() and volatile to __volatile__ so that these headers can be used with gcc's -std=c99. Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> --- diff --git a/include/asm-arm/byteorder.h b/include/asm-arm/byteorder.h index e6f7fcd..39105dc 100644 ---

[patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-17 Thread Mike Frysinger
This changes asm() to __asm__() and volatile to __volatile__ so that these headers can be used with gcc's -std=c99. Signed-off-by: Mike Frysinger [EMAIL PROTECTED] --- diff --git a/include/asm-arm/byteorder.h b/include/asm-arm/byteorder.h index e6f7fcd..39105dc 100644 ---

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-17 Thread Arjan van de Ven
On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: This changes asm() to __asm__() and volatile to __volatile__ so that these headers can be used with gcc's -std=c99. hmm but the kernel doesn't use -std=c99... - To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-17 Thread Arnd Bergmann
On Monday 18 June 2007, Arjan van de Ven wrote: On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: This changes asm() to __asm__() and volatile to __volatile__ so that these headers can be used with gcc's -std=c99. hmm but the kernel doesn't use -std=c99... The byteorder headers

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-17 Thread Mike Frysinger
On Sunday 17 June 2007, Arnd Bergmann wrote: On Monday 18 June 2007, Arjan van de Ven wrote: On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: This changes asm() to __asm__() and volatile to __volatile__ so that these headers can be used with gcc's -std=c99. hmm but the kernel