Re: [patch] use __asm__ rather than asm in asm-s390/ptrace.h

2007-06-18 Thread Heiko Carstens
On Mon, Jun 18, 2007 at 10:15:18AM +0200, Martin Schwidefsky wrote: > On Mon, 2007-06-18 at 09:36 +0200, Heiko Carstens wrote: > > Hmm.. spka is a sort of priviledged instruction and shouldn't be > > user space visible. > > I will move it so it's under #ifdef __KERNEL__. > > Yes, I think this is

Re: [patch] use __asm__ rather than asm in asm-s390/ptrace.h

2007-06-18 Thread Martin Schwidefsky
On Mon, 2007-06-18 at 09:36 +0200, Heiko Carstens wrote: > Hmm.. spka is a sort of priviledged instruction and shouldn't be > user space visible. > I will move it so it's under #ifdef __KERNEL__. Yes, I think this is better. On a side node, why did we add psw_set_key to ptrace.h? processor.h

Re: [patch] use __asm__ rather than asm in asm-s390/ptrace.h

2007-06-18 Thread Heiko Carstens
On Mon, Jun 18, 2007 at 02:23:06AM -0400, Mike Frysinger wrote: > Since asm-s390/ptrace.h is exported to userspace, we need to make sure we use > __asm__() rather than asm() as the latter is disabled when gcc compiles with > GNU extensions turned off (like -std=c99). > > Signed-off-by: Mike

[patch] use __asm__ rather than asm in asm-s390/ptrace.h

2007-06-18 Thread Mike Frysinger
Since asm-s390/ptrace.h is exported to userspace, we need to make sure we use __asm__() rather than asm() as the latter is disabled when gcc compiles with GNU extensions turned off (like -std=c99). Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> --- diff --git a/include/asm-s390/ptrace.h

[patch] use __asm__ rather than asm in asm-s390/ptrace.h

2007-06-18 Thread Mike Frysinger
Since asm-s390/ptrace.h is exported to userspace, we need to make sure we use __asm__() rather than asm() as the latter is disabled when gcc compiles with GNU extensions turned off (like -std=c99). Signed-off-by: Mike Frysinger [EMAIL PROTECTED] --- diff --git a/include/asm-s390/ptrace.h

Re: [patch] use __asm__ rather than asm in asm-s390/ptrace.h

2007-06-18 Thread Heiko Carstens
On Mon, Jun 18, 2007 at 02:23:06AM -0400, Mike Frysinger wrote: Since asm-s390/ptrace.h is exported to userspace, we need to make sure we use __asm__() rather than asm() as the latter is disabled when gcc compiles with GNU extensions turned off (like -std=c99). Signed-off-by: Mike Frysinger

Re: [patch] use __asm__ rather than asm in asm-s390/ptrace.h

2007-06-18 Thread Martin Schwidefsky
On Mon, 2007-06-18 at 09:36 +0200, Heiko Carstens wrote: Hmm.. spka is a sort of priviledged instruction and shouldn't be user space visible. I will move it so it's under #ifdef __KERNEL__. Yes, I think this is better. On a side node, why did we add psw_set_key to ptrace.h? processor.h would

Re: [patch] use __asm__ rather than asm in asm-s390/ptrace.h

2007-06-18 Thread Heiko Carstens
On Mon, Jun 18, 2007 at 10:15:18AM +0200, Martin Schwidefsky wrote: On Mon, 2007-06-18 at 09:36 +0200, Heiko Carstens wrote: Hmm.. spka is a sort of priviledged instruction and shouldn't be user space visible. I will move it so it's under #ifdef __KERNEL__. Yes, I think this is better.