Re: [patch] x86_64, vsyscall: fix the oops crash with __pa_vsymbol()

2007-10-10 Thread Vivek Goyal
On Wed, Oct 10, 2007 at 03:36:58PM +0200, Andi Kleen wrote: > On Wednesday 10 October 2007 03:59:22 Siddha, Suresh B wrote: > > Appended patch fixes an oops while changing the vsyscall sysctl. > > I am sure no one tested this code before integrating into mainline :( > > The original code worked, b

Re: [patch] x86_64, vsyscall: fix the oops crash with __pa_vsymbol()

2007-10-10 Thread Andi Kleen
On Wednesday 10 October 2007 03:59:22 Siddha, Suresh B wrote: > Appended patch fixes an oops while changing the vsyscall sysctl. > I am sure no one tested this code before integrating into mainline :( The original code worked, but got broken by 0dbf7028c0c1f266c9631139450a1502d3cd457e > > BTW, u

[patch] x86_64, vsyscall: fix the oops crash with __pa_vsymbol()

2007-10-09 Thread Siddha, Suresh B
Appended patch fixes an oops while changing the vsyscall sysctl. I am sure no one tested this code before integrating into mainline :( BTW, using ioremap() in vsyscall_sysctl_change() to get the virtual address of a kernel symbol sounds like an over kill.. I wonder if we can define a simple __va_v