Re: [patch] zfcp: spin_lock_irqsave() is not nestable

On 10/24/2016 10:18 AM, Christian Borntraeger wrote: > On 10/14/2016 10:21 PM, Martin K. Petersen wrote: >>> "Steffen" == Steffen Maier writes: >> >> Steffen> could you please queue this as fix for one of my patches that >> Steffen> went into the 4.9 merge window, so for 4.9-rc I guess? >> >>

Re: [patch] zfcp: spin_lock_irqsave() is not nestable

On 10/14/2016 10:21 PM, Martin K. Petersen wrote: >> "Steffen" == Steffen Maier writes: > > Steffen> could you please queue this as fix for one of my patches that > Steffen> went into the 4.9 merge window, so for 4.9-rc I guess? > > Applied to 4.9/scsi-fixes. > FWIW, I do see rcu stall err

Re: [patch] zfcp: spin_lock_irqsave() is not nestable

> "Steffen" == Steffen Maier writes: Steffen> could you please queue this as fix for one of my patches that Steffen> went into the 4.9 merge window, so for 4.9-rc I guess? Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [patch] zfcp: spin_lock_irqsave() is not nestable

On Thu, Oct 13, 2016 at 12:49:18PM +0200, Steffen Maier wrote: > Dan, many thanks for catching this! Sparse did not notice, is there > other tooling that would find such things? This was a Smatch warning. regards, dan carpenter

Re: [patch] zfcp: spin_lock_irqsave() is not nestable

Dan, many thanks for catching this! Sparse did not notice, is there other tooling that would find such things? James, Martin, could you please queue this as fix for one of my patches that went into the 4.9 merge window, so for 4.9-rc I guess? https://lkml.kernel.org/r/20161013085358.GH16198@mw

[patch] zfcp: spin_lock_irqsave() is not nestable

We accidentally overwrite the original saved value of "flags" so that we can't re-enable IRQs at the end of the function. Presumably this function is mostly called with IRQs disabled or it would be obvious in testing. Fixes: aceeffbb59bb ("zfcp: trace full payload of all SAN records (req,resp,ie