Re: [patch -mm] alsa mixer_oss kfree fix

2007-06-05 Thread young dave
Hi, Andrew kfree(NULL) is legal, and is often used. Apart from the null pointer, IMHO,there's two problem need to be fixed, I'm not sure. What's your opinion? 1. the label indent should be removed 2. similar code use different label, some use " __unlock" but others use "__unalloc",

Re: [patch -mm] alsa mixer_oss kfree fix

2007-06-05 Thread young dave
Hi, Andrew kfree(NULL) is legal, and is often used. Apart from the null pointer, IMHO,there's two problem need to be fixed, I'm not sure. What's your opinion? 1. the label indent should be removed 2. similar code use different label, some use __unlock but others use __unalloc, __unlock

Re: [patch -mm] alsa mixer_oss kfree fix

2007-05-31 Thread young dave
Hi, Just append to my email. The reason I read mixer_oss.c is that I see oops in 2.6.22-rc1-mm1, seems oops in mixer_oss.c, but the oops rised only once, I found rc3-mm1 have no change in this file, so I read the source , then post this patch. please find the oops message below: BUG: unable

Re: [patch -mm] alsa mixer_oss kfree fix

2007-05-31 Thread young dave
Hi, kfree(NULL) is legal, and is often used. Really? I don't know this before. Regards dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [patch -mm] alsa mixer_oss kfree fix

2007-05-31 Thread Andrew Morton
On Fri, 1 Jun 2007 01:53:39 + "young dave" <[EMAIL PROTECTED]> wrote: > Fix possible null pointer kfree. kfree(NULL) is legal, and is often used. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

[patch -mm] alsa mixer_oss kfree fix

2007-05-31 Thread young dave
Hi, Fix possible null pointer kfree. Signed-off-by: dave young <[EMAIL PROTECTED]> mixer_oss.c |120 +- 1 file changed, 74 insertions(+), 46 deletions(-) diff -purN linux/sound/core/oss/mixer_oss.c linux.new/sound/core/oss/mixer_oss.c --- linux/sound/core/oss/mixer_oss.c2007-06-01

[patch -mm] alsa mixer_oss kfree fix

2007-05-31 Thread young dave
Hi, Fix possible null pointer kfree. Signed-off-by: dave young [EMAIL PROTECTED] mixer_oss.c |120 +- 1 file changed, 74 insertions(+), 46 deletions(-) diff -purN linux/sound/core/oss/mixer_oss.c linux.new/sound/core/oss/mixer_oss.c --- linux/sound/core/oss/mixer_oss.c2007-06-01

Re: [patch -mm] alsa mixer_oss kfree fix

2007-05-31 Thread Andrew Morton
On Fri, 1 Jun 2007 01:53:39 + young dave [EMAIL PROTECTED] wrote: Fix possible null pointer kfree. kfree(NULL) is legal, and is often used. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch -mm] alsa mixer_oss kfree fix

2007-05-31 Thread young dave
Hi, kfree(NULL) is legal, and is often used. Really? I don't know this before. Regards dave - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [patch -mm] alsa mixer_oss kfree fix

2007-05-31 Thread young dave
Hi, Just append to my email. The reason I read mixer_oss.c is that I see oops in 2.6.22-rc1-mm1, seems oops in mixer_oss.c, but the oops rised only once, I found rc3-mm1 have no change in this file, so I read the source , then post this patch. please find the oops message below: BUG: unable