Re: [patch 00/40] CPU hotplug rework - episode I

2013-02-08 Thread Paul E. McKenney
On Thu, Jan 31, 2013 at 12:11:11PM -, Thomas Gleixner wrote: > The current CPU hotplug implementation has become an increasing > nightmare full of races and undocumented behaviour. The main issue of > the current hotplug scheme is the completely asymetric > startup/teardown process. The

Re: [patch 00/40] CPU hotplug rework - episode I

2013-02-08 Thread Paul E. McKenney
On Thu, Jan 31, 2013 at 12:11:11PM -, Thomas Gleixner wrote: The current CPU hotplug implementation has become an increasing nightmare full of races and undocumented behaviour. The main issue of the current hotplug scheme is the completely asymetric startup/teardown process. The hotplug

Re: [patch 00/40] CPU hotplug rework - episode I

2013-02-06 Thread Rusty Russell
Thomas Gleixner writes: > On Fri, 1 Feb 2013, Linus Torvalds wrote: >> So for me it's the "expose these states" that I get worried about.. A >> random driver should not necessarily even be able to *see* this, and >> decide to be clever and take advantage of the ordering. >> >> So I'd hope there

Re: [patch 00/40] CPU hotplug rework - episode I

2013-02-06 Thread Rusty Russell
Thomas Gleixner t...@linutronix.de writes: On Fri, 1 Feb 2013, Linus Torvalds wrote: So for me it's the expose these states that I get worried about.. A random driver should not necessarily even be able to *see* this, and decide to be clever and take advantage of the ordering. So I'd hope

Re: [patch 00/40] CPU hotplug rework - episode I

2013-02-01 Thread Thomas Gleixner
On Fri, 1 Feb 2013, Linus Torvalds wrote: > On Fri, Feb 1, 2013 at 9:44 AM, Thomas Gleixner wrote: > > > > Just face it. The current hotplug maze has 100+ states which are > > completely undocumented. They are asymetric vs. startup and > > teardown. They just exists and work somehow aside of the

Re: [patch 00/40] CPU hotplug rework - episode I

2013-02-01 Thread Thomas Gleixner
On Fri, 1 Feb 2013, Linus Torvalds wrote: On Fri, Feb 1, 2013 at 9:44 AM, Thomas Gleixner t...@linutronix.de wrote: Just face it. The current hotplug maze has 100+ states which are completely undocumented. They are asymetric vs. startup and teardown. They just exists and work somehow

Re: [patch 00/40] CPU hotplug rework - episode I

2013-01-31 Thread Linus Torvalds
On Fri, Feb 1, 2013 at 9:44 AM, Thomas Gleixner wrote: > > Just face it. The current hotplug maze has 100+ states which are > completely undocumented. They are asymetric vs. startup and > teardown. They just exists and work somehow aside of the occasional > hard to decode hickup. > > Do you

Re: [patch 00/40] CPU hotplug rework - episode I

2013-01-31 Thread Thomas Gleixner
On Fri, 1 Feb 2013, Linus Torvalds wrote: > On Fri, Feb 1, 2013 at 8:48 AM, Thomas Gleixner wrote: > I think we want as many people as possible cc'd on this. You may think > it's an obvious improvement, but maybe it's just because you now > understand the code because you wrote it yourself, not

Re: [patch 00/40] CPU hotplug rework - episode I

2013-01-31 Thread Linus Torvalds
On Fri, Feb 1, 2013 at 8:48 AM, Thomas Gleixner wrote: >> Methinks Tejun needed a cc on this lot ;) > > Not really. I think we want as many people as possible cc'd on this. You may think it's an obvious improvement, but maybe it's just because you now understand the code because you wrote it

Re: [patch 00/40] CPU hotplug rework - episode I

2013-01-31 Thread Thomas Gleixner
On Thu, 31 Jan 2013, Andrew Morton wrote: > On Thu, 31 Jan 2013 15:44:10 - > Thomas Gleixner wrote: > > > At the end hotplug should run through an array of callbacks on both > > sides with explicit core synchronization points. The ordering should > > look like this: > > > > CPUHP_OFFLINE

Re: [patch 00/40] CPU hotplug rework - episode I

2013-01-31 Thread Andrew Morton
On Thu, 31 Jan 2013 15:44:10 - Thomas Gleixner wrote: > At the end hotplug should run through an array of callbacks on both > sides with explicit core synchronization points. The ordering should > look like this: > > CPUHP_OFFLINE // Start state. > CPUHP_PREP_ //

[patch 00/40] CPU hotplug rework - episode I

2013-01-31 Thread Thomas Gleixner
The current CPU hotplug implementation has become an increasing nightmare full of races and undocumented behaviour. The main issue of the current hotplug scheme is the completely asymetric startup/teardown process. The hotplug notifiers are mostly undocumented and the CPU_* actions in lots of

[patch 00/40] CPU hotplug rework - episode I

2013-01-31 Thread Thomas Gleixner
The current CPU hotplug implementation has become an increasing nightmare full of races and undocumented behaviour. The main issue of the current hotplug scheme is the completely asymetric startup/teardown process. The hotplug notifiers are mostly undocumented and the CPU_* actions in lots of

Re: [patch 00/40] CPU hotplug rework - episode I

2013-01-31 Thread Andrew Morton
On Thu, 31 Jan 2013 15:44:10 - Thomas Gleixner t...@linutronix.de wrote: At the end hotplug should run through an array of callbacks on both sides with explicit core synchronization points. The ordering should look like this: CPUHP_OFFLINE // Start state.

Re: [patch 00/40] CPU hotplug rework - episode I

2013-01-31 Thread Thomas Gleixner
On Thu, 31 Jan 2013, Andrew Morton wrote: On Thu, 31 Jan 2013 15:44:10 - Thomas Gleixner t...@linutronix.de wrote: At the end hotplug should run through an array of callbacks on both sides with explicit core synchronization points. The ordering should look like this:

Re: [patch 00/40] CPU hotplug rework - episode I

2013-01-31 Thread Linus Torvalds
On Fri, Feb 1, 2013 at 8:48 AM, Thomas Gleixner t...@linutronix.de wrote: Methinks Tejun needed a cc on this lot ;) Not really. I think we want as many people as possible cc'd on this. You may think it's an obvious improvement, but maybe it's just because you now understand the code because

Re: [patch 00/40] CPU hotplug rework - episode I

2013-01-31 Thread Thomas Gleixner
On Fri, 1 Feb 2013, Linus Torvalds wrote: On Fri, Feb 1, 2013 at 8:48 AM, Thomas Gleixner t...@linutronix.de wrote: I think we want as many people as possible cc'd on this. You may think it's an obvious improvement, but maybe it's just because you now understand the code because you wrote it

Re: [patch 00/40] CPU hotplug rework - episode I

2013-01-31 Thread Linus Torvalds
On Fri, Feb 1, 2013 at 9:44 AM, Thomas Gleixner t...@linutronix.de wrote: Just face it. The current hotplug maze has 100+ states which are completely undocumented. They are asymetric vs. startup and teardown. They just exists and work somehow aside of the occasional hard to decode hickup.