Re: [patch 01/12] mm: oom_kill: remove unnecessary locking in oom_enable()

2015-03-26 Thread David Rientjes
On Wed, 25 Mar 2015, Johannes Weiner wrote: > Setting oom_killer_disabled to false is atomic, there is no need for > further synchronization with ongoing allocations trying to OOM-kill. > > Signed-off-by: Johannes Weiner Acked-by: David Rientjes -- To unsubscribe from this list: send the line

Re: [patch 01/12] mm: oom_kill: remove unnecessary locking in oom_enable()

2015-03-26 Thread David Rientjes
On Thu, 26 Mar 2015, Michal Hocko wrote: > I am wrong here! pagefault_out_of_memory takes the lock and so the whole > mem_cgroup_out_of_memory is called under the same lock. If all userspace processes are frozen by the time oom_killer_disable() is called, then there shouldn't be any race with th

Re: [patch 01/12] mm: oom_kill: remove unnecessary locking in oom_enable()

2015-03-26 Thread Michal Hocko
On Thu 26-03-15 12:51:40, Michal Hocko wrote: > On Wed 25-03-15 17:51:31, David Rientjes wrote: > > On Wed, 25 Mar 2015, Johannes Weiner wrote: > > > > > Setting oom_killer_disabled to false is atomic, there is no need for > > > further synchronization with ongoing allocations trying to OOM-kill.

Re: [patch 01/12] mm: oom_kill: remove unnecessary locking in oom_enable()

2015-03-26 Thread Michal Hocko
On Wed 25-03-15 17:51:31, David Rientjes wrote: > On Wed, 25 Mar 2015, Johannes Weiner wrote: > > > Setting oom_killer_disabled to false is atomic, there is no need for > > further synchronization with ongoing allocations trying to OOM-kill. > > > > Signed-off-by: Johannes Weiner > > --- > > mm

Re: [patch 01/12] mm: oom_kill: remove unnecessary locking in oom_enable()

2015-03-26 Thread Michal Hocko
On Wed 25-03-15 02:17:05, Johannes Weiner wrote: > Setting oom_killer_disabled to false is atomic, there is no need for > further synchronization with ongoing allocations trying to OOM-kill. True, races with an ongoing allocations are not harmful. > Signed-off-by: Johannes Weiner Acked-by: Mich

Re: [patch 01/12] mm: oom_kill: remove unnecessary locking in oom_enable()

2015-03-25 Thread David Rientjes
On Wed, 25 Mar 2015, Johannes Weiner wrote: > Setting oom_killer_disabled to false is atomic, there is no need for > further synchronization with ongoing allocations trying to OOM-kill. > > Signed-off-by: Johannes Weiner > --- > mm/oom_kill.c | 2 -- > 1 file changed, 2 deletions(-) > > diff -

[patch 01/12] mm: oom_kill: remove unnecessary locking in oom_enable()

2015-03-24 Thread Johannes Weiner
Setting oom_killer_disabled to false is atomic, there is no need for further synchronization with ongoing allocations trying to OOM-kill. Signed-off-by: Johannes Weiner --- mm/oom_kill.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 2b665da1b3c9..73763e