Re: [patch 01/14] char/snsc: reorder set_current_state() and add_wait_queue()

2005-03-14 Thread Greg Howard
On Mon, 14 Mar 2005, Jesse Barnes wrote: > On Monday, March 14, 2005 9:54 am, Nishanth Aravamudan wrote: > > On Mon, Mar 14, 2005 at 09:45:44AM -0800, Jesse Barnes wrote: > > > On Sunday, March 6, 2005 2:36 pm, [EMAIL PROTECTED] wrote: > > > > Any comments would be, as always, appreciated. > > >

Re: [patch 01/14] char/snsc: reorder set_current_state() and add_wait_queue()

2005-03-14 Thread Greg Howard
On Mon, 14 Mar 2005, Jesse Barnes wrote: > On Sunday, March 6, 2005 2:36 pm, [EMAIL PROTECTED] wrote: > > Any comments would be, as always, appreciated. > > I don't have a problem with this change, but the maintainer probably should > have been Cc'd. Greg, does this change look ok to you? Note

Re: [patch 01/14] char/snsc: reorder set_current_state() and add_wait_queue()

2005-03-14 Thread Jesse Barnes
On Monday, March 14, 2005 9:54 am, Nishanth Aravamudan wrote: > On Mon, Mar 14, 2005 at 09:45:44AM -0800, Jesse Barnes wrote: > > On Sunday, March 6, 2005 2:36 pm, [EMAIL PROTECTED] wrote: > > > Any comments would be, as always, appreciated. > > > > I don't have a problem with this change, but the

Re: [patch 01/14] char/snsc: reorder set_current_state() and add_wait_queue()

2005-03-14 Thread Nishanth Aravamudan
On Mon, Mar 14, 2005 at 09:45:44AM -0800, Jesse Barnes wrote: > On Sunday, March 6, 2005 2:36 pm, [EMAIL PROTECTED] wrote: > > Any comments would be, as always, appreciated. > > I don't have a problem with this change, but the maintainer probably should > have been Cc'd. Greg, does this change l

Re: [patch 01/14] char/snsc: reorder set_current_state() and add_wait_queue()

2005-03-14 Thread Jesse Barnes
On Sunday, March 6, 2005 2:36 pm, [EMAIL PROTECTED] wrote: > Any comments would be, as always, appreciated. I don't have a problem with this change, but the maintainer probably should have been Cc'd. Greg, does this change look ok to you? Note that it's already been committed to the upstream t

[patch 01/14] char/snsc: reorder set_current_state() and add_wait_queue()

2005-03-06 Thread domen
Any comments would be, as always, appreciated. -Nish Reorder add_wait_queue() and set_current_state() as a signal could be lost in between the two functions. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/char/sns