Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Miklos Szeredi
> >> What happens if the application overwrites what it had written some > >> time later? Nothing. The page is already read-write, the pte dirty, > >> so even though the file was clearly modified, there's absolutely no > >> way in which this can be used to force an update to the timestamp. > >>

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Peter Staubach
Miklos Szeredi wrote: What happens if the application overwrites what it had written some time later? Nothing. The page is already read-write, the pte dirty, so even though the file was clearly modified, there's absolutely no way in which this can be used to force an update to the timestamp.

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Miklos Szeredi
> What happens if the application overwrites what it had written some > time later? Nothing. The page is already read-write, the pte dirty, > so even though the file was clearly modified, there's absolutely no > way in which this can be used to force an update to the timestamp. Which, I realize

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Miklos Szeredi
> >> While these entry points do not actually modify the file itself, > >> as was pointed out, they are handy points at which the kernel gains > >> control and could actually notice that the contents of the file are > >> no longer the same as they were, ie. modified. > >> > >> From the operating

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Peter Staubach
Miklos Szeredi wrote: While these entry points do not actually modify the file itself, as was pointed out, they are handy points at which the kernel gains control and could actually notice that the contents of the file are no longer the same as they were, ie. modified. From the operating

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Miklos Szeredi
> While these entry points do not actually modify the file itself, > as was pointed out, they are handy points at which the kernel gains > control and could actually notice that the contents of the file are > no longer the same as they were, ie. modified. > > From the operating system viewpoint,

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Peter Staubach
Miklos Szeredi wrote: These change still have the undesirable property that although the modified pages may be flushed to stable storage, the metadata on the file will not be updated until the application takes positive action. This is permissible given the current wording in the

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Miklos Szeredi
> These change still have the undesirable property that although the > modified pages may be flushed to stable storage, the metadata on > the file will not be updated until the application takes positive > action. This is permissible given the current wording in the > specifications, but it would

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Peter Staubach
Miklos Szeredi wrote: From: Miklos Szeredi <[EMAIL PROTECTED]> Changes: o moved check from __fput() to remove_vma(), which is more logical o changed set_page_dirty() to set_page_dirty_mapping in hugetlb.c o cleaned up #ifdef CONFIG_BLOCK mess This patch makes writing to shared memory

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Peter Staubach
Miklos Szeredi wrote: From: Miklos Szeredi [EMAIL PROTECTED] Changes: o moved check from __fput() to remove_vma(), which is more logical o changed set_page_dirty() to set_page_dirty_mapping in hugetlb.c o cleaned up #ifdef CONFIG_BLOCK mess This patch makes writing to shared memory

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Miklos Szeredi
These change still have the undesirable property that although the modified pages may be flushed to stable storage, the metadata on the file will not be updated until the application takes positive action. This is permissible given the current wording in the specifications, but it would be

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Peter Staubach
Miklos Szeredi wrote: These change still have the undesirable property that although the modified pages may be flushed to stable storage, the metadata on the file will not be updated until the application takes positive action. This is permissible given the current wording in the

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Miklos Szeredi
While these entry points do not actually modify the file itself, as was pointed out, they are handy points at which the kernel gains control and could actually notice that the contents of the file are no longer the same as they were, ie. modified. From the operating system viewpoint, this

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Peter Staubach
Miklos Szeredi wrote: While these entry points do not actually modify the file itself, as was pointed out, they are handy points at which the kernel gains control and could actually notice that the contents of the file are no longer the same as they were, ie. modified. From the operating

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Miklos Szeredi
While these entry points do not actually modify the file itself, as was pointed out, they are handy points at which the kernel gains control and could actually notice that the contents of the file are no longer the same as they were, ie. modified. From the operating system viewpoint,

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Miklos Szeredi
What happens if the application overwrites what it had written some time later? Nothing. The page is already read-write, the pte dirty, so even though the file was clearly modified, there's absolutely no way in which this can be used to force an update to the timestamp. Which, I realize

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Peter Staubach
Miklos Szeredi wrote: What happens if the application overwrites what it had written some time later? Nothing. The page is already read-write, the pte dirty, so even though the file was clearly modified, there's absolutely no way in which this can be used to force an update to the timestamp.

Re: [patch 01/22] update ctime and mtime for mmaped write

2007-02-28 Thread Miklos Szeredi
What happens if the application overwrites what it had written some time later? Nothing. The page is already read-write, the pte dirty, so even though the file was clearly modified, there's absolutely no way in which this can be used to force an update to the timestamp. Which,

[patch 01/22] update ctime and mtime for mmaped write

2007-02-27 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Changes: o moved check from __fput() to remove_vma(), which is more logical o changed set_page_dirty() to set_page_dirty_mapping in hugetlb.c o cleaned up #ifdef CONFIG_BLOCK mess This patch makes writing to shared memory mappings update st_ctime and

[patch 01/22] update ctime and mtime for mmaped write

2007-02-27 Thread Miklos Szeredi
From: Miklos Szeredi [EMAIL PROTECTED] Changes: o moved check from __fput() to remove_vma(), which is more logical o changed set_page_dirty() to set_page_dirty_mapping in hugetlb.c o cleaned up #ifdef CONFIG_BLOCK mess This patch makes writing to shared memory mappings update st_ctime and