Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Russell King
On Tue, Jan 23, 2007 at 01:59:14PM +0200, Alon Bar-Lev wrote: > On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote: > >> Rossell, I am confused. > >> There are many places in kernel where there is static __initdata > >> without initialization. Should all these be corrected too? Or your > >>

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Alon Bar-Lev
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote: > Rossell, I am confused. > There are many places in kernel where there is static __initdata > without initialization. Should all these be corrected too? Or your > comment applies only to none static global data? From what I remembered from

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Russell King
On Tue, Jan 23, 2007 at 01:31:25PM +0200, Alon Bar-Lev wrote: > On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote: > >> So it will be fine if I initialize it to "" and remove the static from > >> the your example? > > > >Why do you want to remove the static? > > Rossell, I am confused. > There

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Alon Bar-Lev
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote: > So it will be fine if I initialize it to "" and remove the static from > the your example? Why do you want to remove the static? Rossell, I am confused. There are many places in kernel where there is static __initdata without

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Alon Bar-Lev
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote: Why do you want to remove the static? Since current design declare a buffer in main.c which is used by arch specific startup code, mainly setup.c. Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Russell King
On Tue, Jan 23, 2007 at 12:50:15PM +0200, Alon Bar-Lev wrote: > On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote: > >See Message-ID: <[EMAIL PROTECTED]> sent on > >18 January in this thread. Such strings might as well be initialised to > >an empty string. > > So it will be fine if I initialize

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Alon Bar-Lev
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote: See Message-ID: <[EMAIL PROTECTED]> sent on 18 January in this thread. Such strings might as well be initialised to an empty string. So it will be fine if I initialize it to "" and remove the static from the your example? BTW: Is there a

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Russell King
On Tue, Jan 23, 2007 at 12:37:06PM +0200, Alon Bar-Lev wrote: > On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote: > >which reflects precisely what I've been saying concerning the addition > >of __initdata. > > Great! > So what do you thing we should do? > > Modify this: > char __initdata

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Alon Bar-Lev
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote: which reflects precisely what I've been saying concerning the addition of __initdata. Great! So what do you thing we should do? Modify this: char __initdata boot_command_line[COMMAND_LINE_SIZE]; Into: char __initdata

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Alon Bar-Lev
On 1/23/07, Russell King [EMAIL PROTECTED] wrote: which reflects precisely what I've been saying concerning the addition of __initdata. Great! So what do you thing we should do? Modify this: char __initdata boot_command_line[COMMAND_LINE_SIZE]; Into: char __initdata

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Russell King
On Tue, Jan 23, 2007 at 12:37:06PM +0200, Alon Bar-Lev wrote: On 1/23/07, Russell King [EMAIL PROTECTED] wrote: which reflects precisely what I've been saying concerning the addition of __initdata. Great! So what do you thing we should do? Modify this: char __initdata

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Alon Bar-Lev
On 1/23/07, Russell King [EMAIL PROTECTED] wrote: See Message-ID: [EMAIL PROTECTED] sent on 18 January in this thread. Such strings might as well be initialised to an empty string. So it will be fine if I initialize it to and remove the static from the your example? BTW: Is there a

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Russell King
On Tue, Jan 23, 2007 at 12:50:15PM +0200, Alon Bar-Lev wrote: On 1/23/07, Russell King [EMAIL PROTECTED] wrote: See Message-ID: [EMAIL PROTECTED] sent on 18 January in this thread. Such strings might as well be initialised to an empty string. So it will be fine if I initialize it to and

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Alon Bar-Lev
On 1/23/07, Russell King [EMAIL PROTECTED] wrote: Why do you want to remove the static? Since current design declare a buffer in main.c which is used by arch specific startup code, mainly setup.c. Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Alon Bar-Lev
On 1/23/07, Russell King [EMAIL PROTECTED] wrote: So it will be fine if I initialize it to and remove the static from the your example? Why do you want to remove the static? Rossell, I am confused. There are many places in kernel where there is static __initdata without initialization.

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Russell King
On Tue, Jan 23, 2007 at 01:31:25PM +0200, Alon Bar-Lev wrote: On 1/23/07, Russell King [EMAIL PROTECTED] wrote: So it will be fine if I initialize it to and remove the static from the your example? Why do you want to remove the static? Rossell, I am confused. There are many places in

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Alon Bar-Lev
On 1/23/07, Russell King [EMAIL PROTECTED] wrote: Rossell, I am confused. There are many places in kernel where there is static __initdata without initialization. Should all these be corrected too? Or your comment applies only to none static global data? From what I remembered from previous

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-23 Thread Russell King
On Tue, Jan 23, 2007 at 01:59:14PM +0200, Alon Bar-Lev wrote: On 1/23/07, Russell King [EMAIL PROTECTED] wrote: Rossell, I am confused. There are many places in kernel where there is static __initdata without initialization. Should all these be corrected too? Or your comment applies only

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Bernhard Walle
* Russell King <[EMAIL PROTECTED]> [2007-01-22 23:27]: > > which reflects precisely what I've been saying concerning the addition > of __initdata. 100 % correct, thanks. Regards, Bernhard - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Russell King
On Mon, Jan 22, 2007 at 11:14:00PM +0100, Bernhard Walle wrote: > * Russell King <[EMAIL PROTECTED]> [2007-01-18 16:23]: > > On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote: > > > Russell King wrote: > > > > On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: > > > >>

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Bernhard Walle
* Russell King <[EMAIL PROTECTED]> [2007-01-18 16:23]: > On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote: > > Russell King wrote: > > > On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: > > >> -static char command_line[COMMAND_LINE_SIZE]; > > >> +static char

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Alon Bar-Lev
On 1/22/07, Bernhard Walle <[EMAIL PROTECTED]> wrote: I refreshed the patches from Alon against 2.6.20-rc4-mm1. Or was I totally wrong? I don't know what is "Avoid top-posting? ;)" I hope it is a good thing... :) I will look at it again and submit it as requested. Thank you, Alon Bar-Lev. -

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Bernhard Walle
* Andrew Morton <[EMAIL PROTECTED]> [2007-01-22 21:44]: > > > Some general comments... or should I CC other people etc... > > I submitted this several times but got almost no architecture to ACK. > > > > I just don't know how we can progress with this issue... All we wanted > > is to break the

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Andrew Morton
On Mon, 22 Jan 2007 22:31:48 +0200 "Alon Bar-Lev" <[EMAIL PROTECTED]> wrote: > Hello Andrew, > > Can I do anything more in order to be closer to merge? Avoid top-posting? ;) > Some general comments... or should I CC other people etc... > I submitted this several times but got almost no

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Alon Bar-Lev
Hello Andrew, Can I do anything more in order to be closer to merge? Some general comments... or should I CC other people etc... I submitted this several times but got almost no architecture to ACK. I just don't know how we can progress with this issue... All we wanted is to break the 256 limit

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Russell King
On Mon, Jan 22, 2007 at 11:56:50AM -0800, Andrew Morton wrote: > > On Thu, 18 Jan 2007 15:23:26 + Russell King <[EMAIL PROTECTED]> wrote: > > On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote: > > > Russell King wrote: > > > > On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Andrew Morton
> On Thu, 18 Jan 2007 15:23:26 + Russell King <[EMAIL PROTECTED]> wrote: > On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote: > > Russell King wrote: > > > On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: > > >> -static char command_line[COMMAND_LINE_SIZE]; > > >>

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Alon Bar-Lev
On 1/18/07, Bodo Eggert <[EMAIL PROTECTED]> wrote: Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > On 1/18/07, Russell King <[EMAIL PROTECTED]> wrote: >> On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: >> > 2. Set command_line as __initdata. >> You can't. >> >> > -static char

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Alon Bar-Lev
On 1/18/07, Bodo Eggert [EMAIL PROTECTED] wrote: Alon Bar-Lev [EMAIL PROTECTED] wrote: On 1/18/07, Russell King [EMAIL PROTECTED] wrote: On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: 2. Set command_line as __initdata. You can't. -static char

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Andrew Morton
On Thu, 18 Jan 2007 15:23:26 + Russell King [EMAIL PROTECTED] wrote: On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote: Russell King wrote: On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: -static char command_line[COMMAND_LINE_SIZE]; +static char

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Russell King
On Mon, Jan 22, 2007 at 11:56:50AM -0800, Andrew Morton wrote: On Thu, 18 Jan 2007 15:23:26 + Russell King [EMAIL PROTECTED] wrote: On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote: Russell King wrote: On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote:

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Alon Bar-Lev
Hello Andrew, Can I do anything more in order to be closer to merge? Some general comments... or should I CC other people etc... I submitted this several times but got almost no architecture to ACK. I just don't know how we can progress with this issue... All we wanted is to break the 256 limit

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Andrew Morton
On Mon, 22 Jan 2007 22:31:48 +0200 Alon Bar-Lev [EMAIL PROTECTED] wrote: Hello Andrew, Can I do anything more in order to be closer to merge? Avoid top-posting? ;) Some general comments... or should I CC other people etc... I submitted this several times but got almost no architecture to

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Bernhard Walle
* Andrew Morton [EMAIL PROTECTED] [2007-01-22 21:44]: Some general comments... or should I CC other people etc... I submitted this several times but got almost no architecture to ACK. I just don't know how we can progress with this issue... All we wanted is to break the 256 limit in

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Alon Bar-Lev
On 1/22/07, Bernhard Walle [EMAIL PROTECTED] wrote: I refreshed the patches from Alon against 2.6.20-rc4-mm1. Or was I totally wrong? I don't know what is Avoid top-posting? ;) I hope it is a good thing... :) I will look at it again and submit it as requested. Thank you, Alon Bar-Lev. - To

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Bernhard Walle
* Russell King [EMAIL PROTECTED] [2007-01-18 16:23]: On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote: Russell King wrote: On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: -static char command_line[COMMAND_LINE_SIZE]; +static char __initdata

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Russell King
On Mon, Jan 22, 2007 at 11:14:00PM +0100, Bernhard Walle wrote: * Russell King [EMAIL PROTECTED] [2007-01-18 16:23]: On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote: Russell King wrote: On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: -static char

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-22 Thread Bernhard Walle
* Russell King [EMAIL PROTECTED] [2007-01-22 23:27]: which reflects precisely what I've been saying concerning the addition of __initdata. 100 % correct, thanks. Regards, Bernhard - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-19 Thread Bernhard Walle
* Russell King <[EMAIL PROTECTED]> [2007-01-18 16:23]: > > However, there is a bigger question here: that is the tradeoff between > making this variable part of the on-disk kernel image, but throw away > the memory at runtime, or to leave it in the BSS where it will not be > part of the on-disk

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-19 Thread Bernhard Walle
* Russell King [EMAIL PROTECTED] [2007-01-18 16:23]: However, there is a bigger question here: that is the tradeoff between making this variable part of the on-disk kernel image, but throw away the memory at runtime, or to leave it in the BSS where it will not be part of the on-disk kernel

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-18 Thread Bodo Eggert
Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > On 1/18/07, Russell King <[EMAIL PROTECTED]> wrote: >> On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: >> > 2. Set command_line as __initdata. >> You can't. >> >> > -static char command_line[COMMAND_LINE_SIZE]; >> > +static char __initdata

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-18 Thread Alon Bar-Lev
On 1/18/07, Russell King <[EMAIL PROTECTED]> wrote: If you want to place a variable in a specific section, it must be explicitly initialised. Eg, static char __initdata command_line[COMMAND_LINE_SIZE] = ""; However, there is a bigger question here: that is the tradeoff between making this

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-18 Thread Russell King
On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote: > Russell King wrote: > > On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: > >> -static char command_line[COMMAND_LINE_SIZE]; > >> +static char __initdata command_line[COMMAND_LINE_SIZE]; > > > > Uninitialised data is

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-18 Thread Tomas Carnecky
Russell King wrote: > On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: >> -static char command_line[COMMAND_LINE_SIZE]; >> +static char __initdata command_line[COMMAND_LINE_SIZE]; > > Uninitialised data is placed in the BSS. Adding __initdata to BSS > data causes grief. >

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-18 Thread Alon Bar-Lev
On 1/18/07, Russell King <[EMAIL PROTECTED]> wrote: On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: > 2. Set command_line as __initdata. You can't. > -static char command_line[COMMAND_LINE_SIZE]; > +static char __initdata command_line[COMMAND_LINE_SIZE]; Uninitialised data is

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-18 Thread Russell King
On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: > 2. Set command_line as __initdata. You can't. > -static char command_line[COMMAND_LINE_SIZE]; > +static char __initdata command_line[COMMAND_LINE_SIZE]; Uninitialised data is placed in the BSS. Adding __initdata to BSS data

[patch 03/26] Dynamic kernel command-line - arm

2007-01-18 Thread Bernhard Walle
1. Rename saved_command_line into boot_command_line. 2. Set command_line as __initdata. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> --- arch/arm/kernel/setup.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: linux-2.6.20-rc4-mm1/arch/arm/kernel/setup.c

[patch 03/26] Dynamic kernel command-line - arm

2007-01-18 Thread Bernhard Walle
1. Rename saved_command_line into boot_command_line. 2. Set command_line as __initdata. Signed-off-by: Alon Bar-Lev [EMAIL PROTECTED] --- arch/arm/kernel/setup.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: linux-2.6.20-rc4-mm1/arch/arm/kernel/setup.c

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-18 Thread Russell King
On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: 2. Set command_line as __initdata. You can't. -static char command_line[COMMAND_LINE_SIZE]; +static char __initdata command_line[COMMAND_LINE_SIZE]; Uninitialised data is placed in the BSS. Adding __initdata to BSS data causes

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-18 Thread Alon Bar-Lev
On 1/18/07, Russell King [EMAIL PROTECTED] wrote: On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: 2. Set command_line as __initdata. You can't. -static char command_line[COMMAND_LINE_SIZE]; +static char __initdata command_line[COMMAND_LINE_SIZE]; Uninitialised data is

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-18 Thread Tomas Carnecky
Russell King wrote: On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: -static char command_line[COMMAND_LINE_SIZE]; +static char __initdata command_line[COMMAND_LINE_SIZE]; Uninitialised data is placed in the BSS. Adding __initdata to BSS data causes grief. Static

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-18 Thread Russell King
On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote: Russell King wrote: On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: -static char command_line[COMMAND_LINE_SIZE]; +static char __initdata command_line[COMMAND_LINE_SIZE]; Uninitialised data is placed in

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-18 Thread Alon Bar-Lev
On 1/18/07, Russell King [EMAIL PROTECTED] wrote: If you want to place a variable in a specific section, it must be explicitly initialised. Eg, static char __initdata command_line[COMMAND_LINE_SIZE] = ; However, there is a bigger question here: that is the tradeoff between making this

Re: [patch 03/26] Dynamic kernel command-line - arm

2007-01-18 Thread Bodo Eggert
Alon Bar-Lev [EMAIL PROTECTED] wrote: On 1/18/07, Russell King [EMAIL PROTECTED] wrote: On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: 2. Set command_line as __initdata. You can't. -static char command_line[COMMAND_LINE_SIZE]; +static char __initdata

[PATCH 03/26] Dynamic kernel command-line - arm

2006-12-02 Thread Alon Bar-Lev
1. Rename saved_command_line into boot_command_line. 2. Set command_line as __initdata. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.19.org/arch/arm/kernel/setup.c linux-2.6.19/arch/arm/kernel/setup.c --- linux-2.6.19.org/arch/arm/kernel/setup.c2006-11-29

[PATCH 03/26] Dynamic kernel command-line - arm

2006-12-02 Thread Alon Bar-Lev
1. Rename saved_command_line into boot_command_line. 2. Set command_line as __initdata. Signed-off-by: Alon Bar-Lev [EMAIL PROTECTED] --- diff -urNp linux-2.6.19.org/arch/arm/kernel/setup.c linux-2.6.19/arch/arm/kernel/setup.c --- linux-2.6.19.org/arch/arm/kernel/setup.c2006-11-29