Re: [patch 04/11] mm: memcg: push down PageSwapCache check into uncharge entry functions

2012-07-09 Thread Michal Hocko
On Thu 05-07-12 02:44:56, Johannes Weiner wrote: > Not all uncharge paths need to check if the page is swapcache, some of > them can know for sure. > > Push down the check into all callsites of uncharge_common() so that > the patch that removes some of them is more obvious. > > Signed-off-by: Joh

Re: [patch 04/11] mm: memcg: push down PageSwapCache check into uncharge entry functions

2012-07-09 Thread Johannes Weiner
On Mon, Jul 09, 2012 at 11:42:12AM +0900, Kamezawa Hiroyuki wrote: > (2012/07/05 9:44), Johannes Weiner wrote: > > @@ -3278,10 +3283,11 @@ void mem_cgroup_end_migration(struct mem_cgroup > > *memcg, > > unused = oldpage; > > } > > anon = PageAnon(used); > > - __mem_cgroup_unc

Re: [patch 04/11] mm: memcg: push down PageSwapCache check into uncharge entry functions

2012-07-08 Thread Kamezawa Hiroyuki
(2012/07/05 9:44), Johannes Weiner wrote: > Not all uncharge paths need to check if the page is swapcache, some of > them can know for sure. > > Push down the check into all callsites of uncharge_common() so that > the patch that removes some of them is more obvious. > > Signed-off-by: Johannes W