Ingo Molnar wrote:
>> +static inline pmd_t native_make_pmd(unsigned long long val)
>> +{
>> +return (pmd_t) { val };
>> +}
>> +static inline pte_t native_make_pte(unsigned long long val)
>> +{
>> +return (pte_t) { .pte_low = val, .pte_high = (val >> 32) } ;
>> +}
>>
>
> missing
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote:
> Add a set of accessors to pack, unpack and modify page table entries
> (at all levels). This allows a paravirt implementation to control the
> contents of pgd/pmd/pte entries. For example, Xen uses this to
> convert the (pseudo-)physical
* Jeremy Fitzhardinge [EMAIL PROTECTED] wrote:
Add a set of accessors to pack, unpack and modify page table entries
(at all levels). This allows a paravirt implementation to control the
contents of pgd/pmd/pte entries. For example, Xen uses this to
convert the (pseudo-)physical address
Ingo Molnar wrote:
+static inline pmd_t native_make_pmd(unsigned long long val)
+{
+return (pmd_t) { val };
+}
+static inline pte_t native_make_pte(unsigned long long val)
+{
+return (pte_t) { .pte_low = val, .pte_high = (val 32) } ;
+}
missing newlines between inline
Add a set of accessors to pack, unpack and modify page table entries
(at all levels). This allows a paravirt implementation to control the
contents of pgd/pmd/pte entries. For example, Xen uses this to
convert the (pseudo-)physical address into a machine address when
populating a pagetable
Add a set of accessors to pack, unpack and modify page table entries
(at all levels). This allows a paravirt implementation to control the
contents of pgd/pmd/pte entries. For example, Xen uses this to
convert the (pseudo-)physical address into a machine address when
populating a pagetable
On Wed, 2007-02-28 at 09:32 +0100, Ingo Molnar wrote:
> * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote:
>
> > >> +#ifdef CONFIG_PARAVIRT
> > >> +/* After pte_t, etc, have been defined */
> > >> +#include
> > >> +#endif
> > >>
> > >
> > > hm - there's already a CONFIG_PARAVIRT conditional
Ingo Molnar wrote:
>> Yes, but it happens after asm/paravirt.h has already included some
>> things, and it ends up causing problems. paravirt.h still defines
>> various stub functions in the !CONFIG_PARAVIRT case, so it needs to do
>> the includes either way.
>>
>
> hm, it then needs to
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote:
> >> +#ifdef CONFIG_PARAVIRT
> >> +/* After pte_t, etc, have been defined */
> >> +#include
> >> +#endif
> >>
> >
> > hm - there's already a CONFIG_PARAVIRT conditional in
> > asm-i386/paravirt.h.
>
> Yes, but it happens after
* Jeremy Fitzhardinge [EMAIL PROTECTED] wrote:
+#ifdef CONFIG_PARAVIRT
+/* After pte_t, etc, have been defined */
+#include asm/paravirt.h
+#endif
hm - there's already a CONFIG_PARAVIRT conditional in
asm-i386/paravirt.h.
Yes, but it happens after asm/paravirt.h has
Ingo Molnar wrote:
Yes, but it happens after asm/paravirt.h has already included some
things, and it ends up causing problems. paravirt.h still defines
various stub functions in the !CONFIG_PARAVIRT case, so it needs to do
the includes either way.
hm, it then needs to be fixed
On Wed, 2007-02-28 at 09:32 +0100, Ingo Molnar wrote:
* Jeremy Fitzhardinge [EMAIL PROTECTED] wrote:
+#ifdef CONFIG_PARAVIRT
+/* After pte_t, etc, have been defined */
+#include asm/paravirt.h
+#endif
hm - there's already a CONFIG_PARAVIRT conditional in
Ingo Molnar wrote:
> * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote:
>
>
>> ===
>> --- a/arch/i386/kernel/vmlinux.lds.S
>> +++ b/arch/i386/kernel/vmlinux.lds.S
>> @@ -21,6 +21,9 @@
>> #include
>> #include
>> #include
>> +
>>
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote:
> ===
> --- a/arch/i386/kernel/vmlinux.lds.S
> +++ b/arch/i386/kernel/vmlinux.lds.S
> @@ -21,6 +21,9 @@
> #include
> #include
> #include
> +
> +#undef ENTRY
> +#undef ALIGN
hm,
Add a set of accessors to pack, unpack and modify page table entries
(at all levels). This allows a paravirt implementation to control the
contents of pgd/pmd/pte entries. For example, Xen uses this to
convert the (pseudo-)physical address into a machine address when
populating a pagetable
Add a set of accessors to pack, unpack and modify page table entries
(at all levels). This allows a paravirt implementation to control the
contents of pgd/pmd/pte entries. For example, Xen uses this to
convert the (pseudo-)physical address into a machine address when
populating a pagetable
* Jeremy Fitzhardinge [EMAIL PROTECTED] wrote:
===
--- a/arch/i386/kernel/vmlinux.lds.S
+++ b/arch/i386/kernel/vmlinux.lds.S
@@ -21,6 +21,9 @@
#include asm/page.h
#include asm/cache.h
#include asm/boot.h
+
+#undef ENTRY
Ingo Molnar wrote:
* Jeremy Fitzhardinge [EMAIL PROTECTED] wrote:
===
--- a/arch/i386/kernel/vmlinux.lds.S
+++ b/arch/i386/kernel/vmlinux.lds.S
@@ -21,6 +21,9 @@
#include asm/page.h
#include asm/cache.h
#include
18 matches
Mail list logo
