Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache

2007-02-16 Thread Jeremy Fitzhardinge
Christoph Lameter wrote: > On Thu, 15 Feb 2007, Jeremy Fitzhardinge wrote: > > >> Remove the ctor for the pgd cache. There's no point in having the >> cache machinery do this via an indirect call when all pgd are freed in >> the one place anyway. >> > > Great. We finally get rid of this

Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache

2007-02-16 Thread Christoph Lameter
On Thu, 15 Feb 2007, Jeremy Fitzhardinge wrote: > Remove the ctor for the pgd cache. There's no point in having the > cache machinery do this via an indirect call when all pgd are freed in > the one place anyway. Great. We finally get rid of this evil . On second throughts: Are you sure

Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache

2007-02-16 Thread Jeremy Fitzhardinge
Nick Piggin wrote: > Pekka Enberg wrote: >> On 2/16/07, Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: >> >>> Remove the ctor for the pgd cache. There's no point in having the >>> cache machinery do this via an indirect call when all pgd are freed in >>> the one place anyway. >> >> >> The reason

Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache

2007-02-16 Thread Nick Piggin
Pekka Enberg wrote: On 2/16/07, Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: Remove the ctor for the pgd cache. There's no point in having the cache machinery do this via an indirect call when all pgd are freed in the one place anyway. The reason we have slab constructors and destructors

Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache

2007-02-16 Thread Pekka Enberg
On 2/16/07, Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: Remove the ctor for the pgd cache. There's no point in having the cache machinery do this via an indirect call when all pgd are freed in the one place anyway. The reason we have slab constructors and destructors is to _avoid_

Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache

2007-02-16 Thread Pekka Enberg
On 2/16/07, Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Remove the ctor for the pgd cache. There's no point in having the cache machinery do this via an indirect call when all pgd are freed in the one place anyway. The reason we have slab constructors and destructors is to _avoid_

Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache

2007-02-16 Thread Nick Piggin
Pekka Enberg wrote: On 2/16/07, Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Remove the ctor for the pgd cache. There's no point in having the cache machinery do this via an indirect call when all pgd are freed in the one place anyway. The reason we have slab constructors and destructors

Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache

2007-02-16 Thread Jeremy Fitzhardinge
Nick Piggin wrote: Pekka Enberg wrote: On 2/16/07, Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Remove the ctor for the pgd cache. There's no point in having the cache machinery do this via an indirect call when all pgd are freed in the one place anyway. The reason we have slab

Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache

2007-02-16 Thread Christoph Lameter
On Thu, 15 Feb 2007, Jeremy Fitzhardinge wrote: Remove the ctor for the pgd cache. There's no point in having the cache machinery do this via an indirect call when all pgd are freed in the one place anyway. Great. We finally get rid of this evil . On second throughts: Are you sure

Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache

2007-02-16 Thread Jeremy Fitzhardinge
Christoph Lameter wrote: On Thu, 15 Feb 2007, Jeremy Fitzhardinge wrote: Remove the ctor for the pgd cache. There's no point in having the cache machinery do this via an indirect call when all pgd are freed in the one place anyway. Great. We finally get rid of this evil .

Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache

2007-02-15 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Remove the ctor for the pgd cache. There's no point in having the cache machinery do this via an indirect call when all pgd are freed in the one place anyway. Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Acked-by: Zachary Amsden <[EMAIL PROTECTED]>

[patch 07/21] Xen-paravirt: remove ctor for pgd cache

2007-02-15 Thread Jeremy Fitzhardinge
Remove the ctor for the pgd cache. There's no point in having the cache machinery do this via an indirect call when all pgd are freed in the one place anyway. Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> === ---

[patch 07/21] Xen-paravirt: remove ctor for pgd cache

2007-02-15 Thread Jeremy Fitzhardinge
Remove the ctor for the pgd cache. There's no point in having the cache machinery do this via an indirect call when all pgd are freed in the one place anyway. Signed-off-by: Jeremy Fitzhardinge [EMAIL PROTECTED] === ---