Re: [stable] [patch 08/12] NLM: Fix a circular lock dependency in lockd

2007-10-09 Thread Greg KH
On Tue, Oct 09, 2007 at 11:27:57AM -0400, Trond Myklebust wrote: > > Please see the attachment. Thanks, I've applied this to the tree. greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch 08/12] NLM: Fix a circular lock dependency in lockd

2007-10-09 Thread Trond Myklebust
On Tue, 2007-10-09 at 08:13 -0700, Greg KH wrote: > On Tue, Oct 09, 2007 at 11:00:28AM -0400, Trond Myklebust wrote: > > > > On Mon, 2007-10-08 at 22:01 +0200, Roel Kluin wrote: > > > Greg KH wrote: > > > > > > @@ -477,10 +479,15 @@ nlmsvc_testlock(struct svc_rqst *rqstp, > > > > > > if

Re: [patch 08/12] NLM: Fix a circular lock dependency in lockd

2007-10-09 Thread Greg KH
On Tue, Oct 09, 2007 at 11:00:28AM -0400, Trond Myklebust wrote: > > On Mon, 2007-10-08 at 22:01 +0200, Roel Kluin wrote: > > Greg KH wrote: > > > > @@ -477,10 +479,15 @@ nlmsvc_testlock(struct svc_rqst *rqstp, > > > > if (block == NULL) { > > struct file_lock *conf =

Re: [patch 08/12] NLM: Fix a circular lock dependency in lockd

2007-10-09 Thread Trond Myklebust
On Mon, 2007-10-08 at 22:01 +0200, Roel Kluin wrote: > Greg KH wrote: > > @@ -477,10 +479,15 @@ nlmsvc_testlock(struct svc_rqst *rqstp, > > if (block == NULL) { > struct file_lock *conf = kzalloc(sizeof(*conf), GFP_KERNEL); > + struct nlm_host *host; > >

Re: [patch 08/12] NLM: Fix a circular lock dependency in lockd

2007-10-09 Thread Trond Myklebust
On Mon, 2007-10-08 at 22:01 +0200, Roel Kluin wrote: Greg KH wrote: @@ -477,10 +479,15 @@ nlmsvc_testlock(struct svc_rqst *rqstp, if (block == NULL) { struct file_lock *conf = kzalloc(sizeof(*conf), GFP_KERNEL); + struct nlm_host *host;

Re: [patch 08/12] NLM: Fix a circular lock dependency in lockd

2007-10-09 Thread Greg KH
On Tue, Oct 09, 2007 at 11:00:28AM -0400, Trond Myklebust wrote: On Mon, 2007-10-08 at 22:01 +0200, Roel Kluin wrote: Greg KH wrote: @@ -477,10 +479,15 @@ nlmsvc_testlock(struct svc_rqst *rqstp, if (block == NULL) { struct file_lock *conf = kzalloc(sizeof(*conf),

Re: [patch 08/12] NLM: Fix a circular lock dependency in lockd

2007-10-09 Thread Trond Myklebust
On Tue, 2007-10-09 at 08:13 -0700, Greg KH wrote: On Tue, Oct 09, 2007 at 11:00:28AM -0400, Trond Myklebust wrote: On Mon, 2007-10-08 at 22:01 +0200, Roel Kluin wrote: Greg KH wrote: @@ -477,10 +479,15 @@ nlmsvc_testlock(struct svc_rqst *rqstp, if (block == NULL) {

Re: [stable] [patch 08/12] NLM: Fix a circular lock dependency in lockd

2007-10-09 Thread Greg KH
On Tue, Oct 09, 2007 at 11:27:57AM -0400, Trond Myklebust wrote: Please see the attachment. Thanks, I've applied this to the tree. greg k-h - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch 08/12] NLM: Fix a circular lock dependency in lockd

2007-10-08 Thread Roel Kluin
Greg KH wrote: @@ -477,10 +479,15 @@ nlmsvc_testlock(struct svc_rqst *rqstp, if (block == NULL) { struct file_lock *conf = kzalloc(sizeof(*conf), GFP_KERNEL); + struct nlm_host *host; if (conf == NULL) return

[patch 08/12] NLM: Fix a circular lock dependency in lockd

2007-10-08 Thread Greg KH
From: Trond Myklebust <[EMAIL PROTECTED]> commit 255129d1e9ca0ed3d69d5517fae3e03d7ab4b806 in upstream. The problem is that the garbage collector for the 'host' structures nlm_gc_hosts(), holds nlm_host_mutex while calling down to nlmsvc_mark_resources, which, eventually takes the file->f_mutex.

[patch 08/12] NLM: Fix a circular lock dependency in lockd

2007-10-08 Thread Greg KH
From: Trond Myklebust [EMAIL PROTECTED] commit 255129d1e9ca0ed3d69d5517fae3e03d7ab4b806 in upstream. The problem is that the garbage collector for the 'host' structures nlm_gc_hosts(), holds nlm_host_mutex while calling down to nlmsvc_mark_resources, which, eventually takes the file-f_mutex. We

Re: [patch 08/12] NLM: Fix a circular lock dependency in lockd

2007-10-08 Thread Roel Kluin
Greg KH wrote: @@ -477,10 +479,15 @@ nlmsvc_testlock(struct svc_rqst *rqstp, if (block == NULL) { struct file_lock *conf = kzalloc(sizeof(*conf), GFP_KERNEL); + struct nlm_host *host; if (conf == NULL) return