Re: [patch 097/101] revert "drivers/net/tulip/dmfe: support basic carrier detection"

2007-03-07 Thread Linus Torvalds
On Wed, 7 Mar 2007, Dan Williams wrote: > > Definitely right. If it doesn't work for your card, it needs to be > fixed for your card. Well, regressions are regressions. And they are a *lot* more important than any new features. If it doesn't work, it gets reverted. Linus -

Re: [patch 097/101] revert "drivers/net/tulip/dmfe: support basic carrier detection"

2007-03-07 Thread Dan Williams
On Wed, 2007-03-07 at 10:14 -0800, Stephen Hemminger wrote: > On Wed, 07 Mar 2007 09:12:12 -0800 > Greg KH <[EMAIL PROTECTED]> wrote: > > > > > From: Andrew Morton <[EMAIL PROTECTED]> > > > > Revert 7628b0a8c01a02966d2228bdf741ddedb128e8f8. Thomas Bachler > > reports: > > > > Commit

Re: [patch 097/101] revert "drivers/net/tulip/dmfe: support basic carrier detection"

2007-03-07 Thread Stephen Hemminger
On Wed, 07 Mar 2007 09:12:12 -0800 Greg KH <[EMAIL PROTECTED]> wrote: > > From: Andrew Morton <[EMAIL PROTECTED]> > > Revert 7628b0a8c01a02966d2228bdf741ddedb128e8f8. Thomas Bachler > reports: > > Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe: > support basic

[patch 097/101] revert "drivers/net/tulip/dmfe: support basic carrier detection"

2007-03-07 Thread Greg KH
From: Andrew Morton <[EMAIL PROTECTED]> Revert 7628b0a8c01a02966d2228bdf741ddedb128e8f8. Thomas Bachler reports: Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe: support basic carrier detection) breaks networking on my Davicom DM9009. ethtool always reports there

[patch 097/101] revert drivers/net/tulip/dmfe: support basic carrier detection

2007-03-07 Thread Greg KH
From: Andrew Morton [EMAIL PROTECTED] Revert 7628b0a8c01a02966d2228bdf741ddedb128e8f8. Thomas Bachler reports: Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe: support basic carrier detection) breaks networking on my Davicom DM9009. ethtool always reports there

Re: [patch 097/101] revert drivers/net/tulip/dmfe: support basic carrier detection

2007-03-07 Thread Stephen Hemminger
On Wed, 07 Mar 2007 09:12:12 -0800 Greg KH [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Revert 7628b0a8c01a02966d2228bdf741ddedb128e8f8. Thomas Bachler reports: Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe: support basic carrier

Re: [patch 097/101] revert drivers/net/tulip/dmfe: support basic carrier detection

2007-03-07 Thread Dan Williams
On Wed, 2007-03-07 at 10:14 -0800, Stephen Hemminger wrote: On Wed, 07 Mar 2007 09:12:12 -0800 Greg KH [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Revert 7628b0a8c01a02966d2228bdf741ddedb128e8f8. Thomas Bachler reports: Commit

Re: [patch 097/101] revert drivers/net/tulip/dmfe: support basic carrier detection

2007-03-07 Thread Linus Torvalds
On Wed, 7 Mar 2007, Dan Williams wrote: Definitely right. If it doesn't work for your card, it needs to be fixed for your card. Well, regressions are regressions. And they are a *lot* more important than any new features. If it doesn't work, it gets reverted. Linus - To