Re: [patch 1/1] selinux: do not clear f_op when removing entries

2007-11-21 Thread James Morris
On Wed, 21 Nov 2007, Stephen Smalley wrote: > Do not clear f_op when removing entries since it isn't safe to do. > > Signed-off-by: Stephen Smalley <[EMAIL PROTECTED]> Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm -- James Morris <[EMAIL

Re: [patch 1/1] selinux: do not clear f_op when removing entries

2007-11-21 Thread Christoph Hellwig
On Wed, Nov 21, 2007 at 09:01:36AM -0500, Stephen Smalley wrote: > Do not clear f_op when removing entries since it isn't safe to do. If this is still safe for selinux I'm fine with it. It also gets rid of one of them few remaining s_files users which is always good. Btw, after this patch we

[patch 1/1] selinux: do not clear f_op when removing entries

2007-11-21 Thread Stephen Smalley
On Tue, 2007-11-20 at 15:17 +, Christoph Hellwig wrote: > On Tue, Nov 20, 2007 at 10:05:05AM -0500, Stephen Smalley wrote: > > > Nice, getting rid of this is a very good step formwards. Unfortunately > > > we have another copy of this junk in > > >

[patch 1/1] selinux: do not clear f_op when removing entries

2007-11-21 Thread Stephen Smalley
On Tue, 2007-11-20 at 15:17 +, Christoph Hellwig wrote: On Tue, Nov 20, 2007 at 10:05:05AM -0500, Stephen Smalley wrote: Nice, getting rid of this is a very good step formwards. Unfortunately we have another copy of this junk in security/selinux/selinuxfs.c:sel_remove_entries()

Re: [patch 1/1] selinux: do not clear f_op when removing entries

2007-11-21 Thread Christoph Hellwig
On Wed, Nov 21, 2007 at 09:01:36AM -0500, Stephen Smalley wrote: Do not clear f_op when removing entries since it isn't safe to do. If this is still safe for selinux I'm fine with it. It also gets rid of one of them few remaining s_files users which is always good. Btw, after this patch we

Re: [patch 1/1] selinux: do not clear f_op when removing entries

2007-11-21 Thread James Morris
On Wed, 21 Nov 2007, Stephen Smalley wrote: Do not clear f_op when removing entries since it isn't safe to do. Signed-off-by: Stephen Smalley [EMAIL PROTECTED] Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm -- James Morris [EMAIL PROTECTED] - To