Re: [patch 1/2] arch: invoke oom-killer from page fault

2013-06-06 Thread Michal Hocko
On Thu 06-06-13 00:36:20, Johannes Weiner wrote: > On Wed, Jun 05, 2013 at 08:57:44PM -0700, David Rientjes wrote: > > On Wed, 5 Jun 2013, Johannes Weiner wrote: > > > > > Since '1c0fe6e mm: invoke oom-killer from page fault', page fault > > > handlers should not directly kill faulting tasks in an

Re: [patch 1/2] arch: invoke oom-killer from page fault

2013-06-05 Thread Vineet Gupta
On 06/06/2013 10:06 AM, Johannes Weiner wrote: > From: Johannes Weiner > Subject: [patch] mm: invoke oom-killer from remaining unconverted page fault > handlers > > A few remaining architectures directly kill the page faulting task in > an out of memory situation. This is usually not a good ide

Re: [patch 1/2] arch: invoke oom-killer from page fault

2013-06-05 Thread David Rientjes
On Thu, 6 Jun 2013, Johannes Weiner wrote: > From: Johannes Weiner > Subject: [patch] mm: invoke oom-killer from remaining unconverted page fault > handlers > > A few remaining architectures directly kill the page faulting task in > an out of memory situation. This is usually not a good idea s

Re: [patch 1/2] arch: invoke oom-killer from page fault

2013-06-05 Thread Johannes Weiner
On Wed, Jun 05, 2013 at 08:57:44PM -0700, David Rientjes wrote: > On Wed, 5 Jun 2013, Johannes Weiner wrote: > > > Since '1c0fe6e mm: invoke oom-killer from page fault', page fault > > handlers should not directly kill faulting tasks in an out of memory > > condition. > > I have no objection to t

Re: [patch 1/2] arch: invoke oom-killer from page fault

2013-06-05 Thread David Rientjes
On Wed, 5 Jun 2013, Johannes Weiner wrote: > Since '1c0fe6e mm: invoke oom-killer from page fault', page fault > handlers should not directly kill faulting tasks in an out of memory > condition. I have no objection to the patch, but there's no explanation given here why exiting with a kill shoul

[patch 1/2] arch: invoke oom-killer from page fault

2013-06-05 Thread Johannes Weiner
Since '1c0fe6e mm: invoke oom-killer from page fault', page fault handlers should not directly kill faulting tasks in an out of memory condition. Instead, they should be invoking the OOM killer to pick the right task. Convert the remaining architectures. Signed-off-by: Johannes Weiner --- arch