Re: [patch 1/2] mm: fincore()

2013-05-29 Thread Andres Freund
On 2013-05-29 13:32:23 -0400, Johannes Weiner wrote: > On Wed, May 29, 2013 at 04:53:12PM +0200, Andres Freund wrote: > > On 2013-02-16 14:53:43 +1030, Rusty Russell wrote: > > > Andrew Morton writes: > > > > On Fri, 15 Feb 2013 18:13:04 -0500 > > > > Johannes Weiner wrote: > > > >> I dunno. The

Re: [patch 1/2] mm: fincore()

2013-05-29 Thread Johannes Weiner
On Wed, May 29, 2013 at 04:53:12PM +0200, Andres Freund wrote: > On 2013-02-16 14:53:43 +1030, Rusty Russell wrote: > > Andrew Morton writes: > > > On Fri, 15 Feb 2013 18:13:04 -0500 > > > Johannes Weiner wrote: > > >> I dunno. The byte vector might not be optimal but its worst cases > > >> seem

Re: [patch 1/2] mm: fincore()

2013-05-29 Thread Andres Freund
On 2013-02-16 14:53:43 +1030, Rusty Russell wrote: > Andrew Morton writes: > > On Fri, 15 Feb 2013 18:13:04 -0500 > > Johannes Weiner wrote: > >> I dunno. The byte vector might not be optimal but its worst cases > >> seem more attractive, is just as extensible, and dead simple to use. > > > > Bu

Re: [patch 1/2] mm: fincore()

2013-02-19 Thread Simon Jeons
From: Johannes Weiner Subject: [patch 1/2] mm: fincore() Provide a syscall to determine whether a given file's pages are cached in memory. This is more elegant than mmapping the file for the sole purpose of using mincore(), and also works on NOMMU. Who is the user of mincore()/fincore()

Re: [patch 1/2] mm: fincore()

2013-02-17 Thread Rusty Russell
Andrew Morton writes: > The syscall should handle the common usages very well. But it > shouldn't handle uncommon usages very badly! If the user is actually dealing with the contents of the file, following the established mincore is preferred, since it's in the noise anyway. Which comes back to

Re: [patch 1/2] mm: fincore()

2013-02-17 Thread Andrew Morton
On Sat, 16 Feb 2013 14:53:43 +1030 Rusty Russell wrote: > Andrew Morton writes: > > On Fri, 15 Feb 2013 18:13:04 -0500 > > Johannes Weiner wrote: > >> I dunno. The byte vector might not be optimal but its worst cases > >> seem more attractive, is just as extensible, and dead simple to use. > >

Re: [patch 1/2] mm: fincore()

2013-02-17 Thread Johannes Weiner
On Sat, Feb 16, 2013 at 02:53:43PM +1030, Rusty Russell wrote: > Andrew Morton writes: > > On Fri, 15 Feb 2013 18:13:04 -0500 > > Johannes Weiner wrote: > >> I dunno. The byte vector might not be optimal but its worst cases > >> seem more attractive, is just as extensible, and dead simple to use

Re: [patch 1/2] mm: fincore()

2013-02-17 Thread Rusty Russell
Andrew Morton writes: > On Fri, 15 Feb 2013 18:13:04 -0500 > Johannes Weiner wrote: >> I dunno. The byte vector might not be optimal but its worst cases >> seem more attractive, is just as extensible, and dead simple to use. > > But I think "which pages from this 4TB file are in core" will not b

Re: [patch 1/2] mm: fincore()

2013-02-15 Thread Andrew Morton
On Fri, 15 Feb 2013 18:13:04 -0500 Johannes Weiner wrote: > On Fri, Feb 15, 2013 at 01:27:38PM -0800, Andrew Morton wrote: > > On Fri, 15 Feb 2013 01:34:50 -0500 > > Johannes Weiner wrote: > > > > > + * The status is returned in a vector of bytes. The least significant > > > + * bit of each by

Re: [patch 1/2] mm: fincore()

2013-02-15 Thread Johannes Weiner
On Fri, Feb 15, 2013 at 01:27:38PM -0800, Andrew Morton wrote: > On Fri, 15 Feb 2013 01:34:50 -0500 > Johannes Weiner wrote: > > > + * The status is returned in a vector of bytes. The least significant > > + * bit of each byte is 1 if the referenced page is in memory, otherwise > > + * it is zer

Re: [patch 1/2] mm: fincore()

2013-02-15 Thread Andrew Morton
On Fri, 15 Feb 2013 17:28:03 -0500 Johannes Weiner wrote: > > Yes, and there will be immediate calmour to add more goodies to the > > other seven bits. PageDirty, referenced state, etc. We should think > > about this now, at the design stage rather than grafting things on > > later. > > I'm in

Re: [patch 1/2] mm: fincore()

2013-02-15 Thread Johannes Weiner
On Fri, Feb 15, 2013 at 01:14:51PM -0800, Andrew Morton wrote: > On Fri, 15 Feb 2013 01:34:50 -0500 > Johannes Weiner wrote: > > > On Mon, Feb 11, 2013 at 02:12:39PM -0800, Andrew Morton wrote: > > > Also, having to mmap the file to be able to query pagecache state is a > > > hack. Whatever happ

Re: [patch 1/2] mm: fincore()

2013-02-15 Thread Andrew Morton
On Fri, 15 Feb 2013 01:34:50 -0500 Johannes Weiner wrote: > + * The status is returned in a vector of bytes. The least significant > + * bit of each byte is 1 if the referenced page is in memory, otherwise > + * it is zero. Also, this is going to be dreadfully inefficient for some obvious cases

Re: [patch 1/2] mm: fincore()

2013-02-15 Thread Andrew Morton
On Fri, 15 Feb 2013 01:34:50 -0500 Johannes Weiner wrote: > On Mon, Feb 11, 2013 at 02:12:39PM -0800, Andrew Morton wrote: > > Also, having to mmap the file to be able to query pagecache state is a > > hack. Whatever happened to the fincore() patch? > > I don't know, but how about this one: Th

Re: [patch 1/2] mm: fincore()

2013-02-15 Thread David Miller
From: Johannes Weiner Date: Fri, 15 Feb 2013 01:34:50 -0500 > + nr_pages = DIV_ROUND_UP(len, PAGE_CACHE_SIZE); A small nit, maybe use PAGE_CACHE_ALIGN() here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

[patch 1/2] mm: fincore()

2013-02-14 Thread Johannes Weiner
On Mon, Feb 11, 2013 at 02:12:39PM -0800, Andrew Morton wrote: > Also, having to mmap the file to be able to query pagecache state is a > hack. Whatever happened to the fincore() patch? I don't know, but how about this one: --- From: Johannes Weiner Subject: [patch 1/2] mm: fincore