Re: [patch 1/2] move WARN_ON() out of line

2008-01-05 Thread Dmitri Vorobiev
Arjan van de Ven пишет: > Subject: move WARN_ON() out of line > From: Arjan van de Ven <[EMAIL PROTECTED]> > CC: Ingo Molnar <[EMAIL PROTECTED]> > CC: Andrew Morton <[EMAIL PROTECTED]> > CC: Olof Johansson <[EMAIL PROTECTED]> > CC: Matt Meckall <[EMAIL PROTECTED]> > > A quick grep shows that

Re: [patch 1/2] move WARN_ON() out of line

2008-01-05 Thread Adrian Bunk
On Fri, Jan 04, 2008 at 08:41:49AM +0100, Ingo Molnar wrote: >... > i'm wondering how we could put this into x86.git to get it tested some > more. >... Please don't make x86.git a testing tree for not x86 specific stuff. The right place for getting stuff tested is -mm, and when looking at

Re: [patch 1/2] move WARN_ON() out of line

2008-01-05 Thread Adrian Bunk
On Fri, Jan 04, 2008 at 08:41:49AM +0100, Ingo Molnar wrote: ... i'm wondering how we could put this into x86.git to get it tested some more. ... Please don't make x86.git a testing tree for not x86 specific stuff. The right place for getting stuff tested is -mm, and when looking at

Re: [patch 1/2] move WARN_ON() out of line

2008-01-05 Thread Dmitri Vorobiev
Arjan van de Ven пишет: Subject: move WARN_ON() out of line From: Arjan van de Ven [EMAIL PROTECTED] CC: Ingo Molnar [EMAIL PROTECTED] CC: Andrew Morton [EMAIL PROTECTED] CC: Olof Johansson [EMAIL PROTECTED] CC: Matt Meckall [EMAIL PROTECTED] A quick grep shows that there are currently

Re: [patch 1/2] move WARN_ON() out of line

2008-01-04 Thread Olof Johansson
Hi, On Thu, Jan 03, 2008 at 10:26:05PM +0100, Arjan van de Ven wrote: > This patch build on top of Olof's patch that introduces __WARN, > and places the slowpath out of line. It also uses Ingo's suggestion > to not use __FUNCTION__ but to use kallsyms to do the lookup; > this saves a ton of

Re: [patch 1/2] move WARN_ON() out of line

2008-01-04 Thread Olof Johansson
On Fri, Jan 04, 2008 at 08:41:49AM +0100, Ingo Molnar wrote: > > * Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > This patch build on top of Olof's patch that introduces __WARN, and > > places the slowpath out of line. It also uses Ingo's suggestion to not > > use __FUNCTION__ but to use

Re: [patch 1/2] move WARN_ON() out of line

2008-01-04 Thread Olof Johansson
On Fri, Jan 04, 2008 at 08:41:49AM +0100, Ingo Molnar wrote: * Arjan van de Ven [EMAIL PROTECTED] wrote: This patch build on top of Olof's patch that introduces __WARN, and places the slowpath out of line. It also uses Ingo's suggestion to not use __FUNCTION__ but to use kallsyms to

Re: [patch 1/2] move WARN_ON() out of line

2008-01-04 Thread Olof Johansson
Hi, On Thu, Jan 03, 2008 at 10:26:05PM +0100, Arjan van de Ven wrote: This patch build on top of Olof's patch that introduces __WARN, and places the slowpath out of line. It also uses Ingo's suggestion to not use __FUNCTION__ but to use kallsyms to do the lookup; this saves a ton of extra

Re: [patch 1/2] move WARN_ON() out of line

2008-01-03 Thread Ingo Molnar
* Arjan van de Ven <[EMAIL PROTECTED]> wrote: > This patch build on top of Olof's patch that introduces __WARN, and > places the slowpath out of line. It also uses Ingo's suggestion to not > use __FUNCTION__ but to use kallsyms to do the lookup; this saves a > ton of extra space since gcc

Re: [patch 1/2] move WARN_ON() out of line

2008-01-03 Thread Matt Mackall
On Thu, 2008-01-03 at 22:26 +0100, Arjan van de Ven wrote: > Subject: move WARN_ON() out of line > From: Arjan van de Ven <[EMAIL PROTECTED]> > CC: Ingo Molnar <[EMAIL PROTECTED]> > CC: Andrew Morton <[EMAIL PROTECTED]> > CC: Olof Johansson <[EMAIL PROTECTED]> > CC: Matt Meckall <[EMAIL

[patch 1/2] move WARN_ON() out of line

2008-01-03 Thread Arjan van de Ven
Subject: move WARN_ON() out of line From: Arjan van de Ven <[EMAIL PROTECTED]> CC: Ingo Molnar <[EMAIL PROTECTED]> CC: Andrew Morton <[EMAIL PROTECTED]> CC: Olof Johansson <[EMAIL PROTECTED]> CC: Matt Meckall <[EMAIL PROTECTED]> A quick grep shows that there are currently 1145 instances of

[patch 1/2] move WARN_ON() out of line

2008-01-03 Thread Arjan van de Ven
Subject: move WARN_ON() out of line From: Arjan van de Ven [EMAIL PROTECTED] CC: Ingo Molnar [EMAIL PROTECTED] CC: Andrew Morton [EMAIL PROTECTED] CC: Olof Johansson [EMAIL PROTECTED] CC: Matt Meckall [EMAIL PROTECTED] A quick grep shows that there are currently 1145 instances of WARN_ON in the

Re: [patch 1/2] move WARN_ON() out of line

2008-01-03 Thread Matt Mackall
On Thu, 2008-01-03 at 22:26 +0100, Arjan van de Ven wrote: Subject: move WARN_ON() out of line From: Arjan van de Ven [EMAIL PROTECTED] CC: Ingo Molnar [EMAIL PROTECTED] CC: Andrew Morton [EMAIL PROTECTED] CC: Olof Johansson [EMAIL PROTECTED] CC: Matt Meckall [EMAIL PROTECTED] A quick

Re: [patch 1/2] move WARN_ON() out of line

2008-01-03 Thread Ingo Molnar
* Arjan van de Ven [EMAIL PROTECTED] wrote: This patch build on top of Olof's patch that introduces __WARN, and places the slowpath out of line. It also uses Ingo's suggestion to not use __FUNCTION__ but to use kallsyms to do the lookup; this saves a ton of extra space since gcc doesn't