Re: [patch 1/2] sched: fix idle load balancing in softirqd context

2007-02-21 Thread Andrew Morton
On Fri, 16 Feb 2007 18:03:35 -0800 "Siddha, Suresh B" <[EMAIL PROTECTED]> wrote: > + int cpu = smp_processor_id(), idle_at_tick = idle_cpu(cpu); argh. Please, do int cpu = smp_processor_id(); int idle_at_tick = idle_cpu(cpu); - To unsubscribe from this list: send the line

Re: [patch 1/2] sched: fix idle load balancing in softirqd context

2007-02-21 Thread Andrew Morton
On Fri, 16 Feb 2007 18:03:35 -0800 Siddha, Suresh B [EMAIL PROTECTED] wrote: + int cpu = smp_processor_id(), idle_at_tick = idle_cpu(cpu); argh. Please, do int cpu = smp_processor_id(); int idle_at_tick = idle_cpu(cpu); - To unsubscribe from this list: send the line

Re: [patch 1/2] sched: fix idle load balancing in softirqd context

2007-02-20 Thread Siddha, Suresh B
On Sat, Feb 17, 2007 at 09:42:16AM -0500, Steven Rostedt wrote: > On Fri, 16 Feb 2007, Siddha, Suresh B wrote: > > - int cpu = smp_processor_id(); > > + int cpu = smp_processor_id(), idle_at_tick = idle_cpu(cpu); > > struct rq *rq = cpu_rq(cpu); > > > > But I would recommend that the

Re: [patch 1/2] sched: fix idle load balancing in softirqd context

2007-02-20 Thread Siddha, Suresh B
On Sat, Feb 17, 2007 at 09:42:16AM -0500, Steven Rostedt wrote: On Fri, 16 Feb 2007, Siddha, Suresh B wrote: - int cpu = smp_processor_id(); + int cpu = smp_processor_id(), idle_at_tick = idle_cpu(cpu); struct rq *rq = cpu_rq(cpu); But I would recommend that the idle_at_tick

Re: [patch 1/2] sched: fix idle load balancing in softirqd context

2007-02-17 Thread Steven Rostedt
On Fri, 16 Feb 2007, Siddha, Suresh B wrote: > Periodic load balancing in recent kernels happen in the softirq. > In certain -rt configurations, these softirqs are handled in softirqd > context. And hence the check for idle processor was always returning > busy (as nr_running > 1). > > This

Re: [patch 1/2] sched: fix idle load balancing in softirqd context

2007-02-17 Thread Steven Rostedt
On Fri, 16 Feb 2007, Siddha, Suresh B wrote: Periodic load balancing in recent kernels happen in the softirq. In certain -rt configurations, these softirqs are handled in softirqd context. And hence the check for idle processor was always returning busy (as nr_running 1). This patch

[patch 1/2] sched: fix idle load balancing in softirqd context

2007-02-16 Thread Siddha, Suresh B
Periodic load balancing in recent kernels happen in the softirq. In certain -rt configurations, these softirqs are handled in softirqd context. And hence the check for idle processor was always returning busy (as nr_running > 1). This patch captures the idle information at the tick and passes

[patch 1/2] sched: fix idle load balancing in softirqd context

2007-02-16 Thread Siddha, Suresh B
Periodic load balancing in recent kernels happen in the softirq. In certain -rt configurations, these softirqs are handled in softirqd context. And hence the check for idle processor was always returning busy (as nr_running 1). This patch captures the idle information at the tick and passes this