On Wed, 25 Jul 2007 11:09:21 +1000 Paul Mackerras <[EMAIL PROTECTED]> wrote:
> Also, I prefer the style where the ? and : operators have a space
> after them but not before them, rather than a space either side.
Could I point out that your likes and dislikes are immaterial? The whole
point here
Andy Whitcroft writes:
> Ok, this is something we need to decide on. Currently we only ask for
> consistent spacing on all the mathematic operators. This is mostly as
> we do see a large number of non-spaced uses in defines and the like.
>
> I am happy to expand these tests so they are always s
On Tue, 24 Jul 2007 08:37:09 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Andy Whitcroft wrote:
> > Andrew Morton wrote:
> >
> >>> + start_sector = req->sector*priv->blocking_factor;
> >>> + sectors = req->nr_sectors*priv->blocking_factor;
> >> s/*/ * /. checkpatch missed this.
> >
> > Ok, th
Andreas Schwab wrote:
Jeff Garzik <[EMAIL PROTECTED]> writes:
Andy Whitcroft wrote:
Andrew Morton wrote:
+ start_sector = req->sector*priv->blocking_factor;
+ sectors = req->nr_sectors*priv->blocking_factor;
s/*/ * /. checkpatch missed this.
Ok, this is something we need to de
Jeff Garzik <[EMAIL PROTECTED]> writes:
> Andy Whitcroft wrote:
>> Andrew Morton wrote:
>>
+ start_sector = req->sector*priv->blocking_factor;
+ sectors = req->nr_sectors*priv->blocking_factor;
>>> s/*/ * /. checkpatch missed this.
>>
>> Ok, this is something we need to decide on.
Andy Whitcroft wrote:
Andrew Morton wrote:
+ start_sector = req->sector*priv->blocking_factor;
+ sectors = req->nr_sectors*priv->blocking_factor;
s/*/ * /. checkpatch missed this.
Ok, this is something we need to decide on. Currently we only ask for
consistent spacing on all th
Andrew Morton wrote:
>> +start_sector = req->sector*priv->blocking_factor;
>> +sectors = req->nr_sectors*priv->blocking_factor;
>
> s/*/ * /. checkpatch missed this.
Ok, this is something we need to decide on. Currently we only ask for
consistent spacing on all the mathematic operators
Hi Andrew,
On Thu, 19 Jul 2007, Andrew Morton wrote:
> On Thu, 19 Jul 2007 10:57:53 +0200 (CEST) Geert Uytterhoeven <[EMAIL
> PROTECTED]> wrote:
> > On Wed, 18 Jul 2007, Andrew Morton wrote:
> > > Your patchset significantly hits powerpc, scsi and block. So who gets to
> > > merge this?
On Thu, 19 Jul 2007 14:13:33 +0200 (CEST),
Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> Any chance this will change? I already added a mutex to ps3disk to protect
> against this.
Probably not in the near future. A mutex looks like a good idea though,
since one never knows (and the driver core
On Thu, 19 Jul 2007, Cornelia Huck wrote:
> On Thu, 19 Jul 2007 11:36:31 +0200 (CEST),
> Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
>
> > We have a probe thread that checks for new storage devices and adds them to
> > the
> > bus with ps3_system_bus_device_register(), which calls device_regist
On Thu, 19 Jul 2007 11:36:31 +0200 (CEST),
Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> We have a probe thread that checks for new storage devices and adds them to
> the
> bus with ps3_system_bus_device_register(), which calls device_register().
>
> I guess the actual bus probe() routine gets
On Thu, 19 Jul 2007, Cornelia Huck wrote:
> On Thu, 19 Jul 2007 10:57:53 +0200 (CEST),
> Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
>
> > Were .probe()/.remove() made concurrent again? I thought that idea was
> > dropped
> > because it caused too many problems?
>
> Well, for a given device, -
On Thu, 19 Jul 2007 10:57:53 +0200 (CEST),
Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> Were .probe()/.remove() made concurrent again? I thought that idea was dropped
> because it caused too many problems?
Well, for a given device, ->probe()/->remove() are locked by dev->sem,
so that there can
On Thu, 19 Jul 2007 10:57:53 +0200 (CEST) Geert Uytterhoeven <[EMAIL
PROTECTED]> wrote:
> Hi Andrew,
>
> On Wed, 18 Jul 2007, Andrew Morton wrote:
> > On Mon, 16 Jul 2007 18:15:40 +0200
> > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> >
> > > From: Geert Uytterhoeven <[EMAIL PROTECTED]
Hi Andrew,
On Wed, 18 Jul 2007, Andrew Morton wrote:
> On Mon, 16 Jul 2007 18:15:40 +0200
> Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
>
> > From: Geert Uytterhoeven <[EMAIL PROTECTED]>
> >
> > Add a Disk Storage Driver for the PS3:
>
> Your patchset significantly hits powerpc, scsi
On Thu, 19 Jul 2007, Jens Axboe wrote:
> On Wed, Jul 18 2007, Andrew Morton wrote:
> > On Mon, 16 Jul 2007 18:15:40 +0200
> > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> >
> > > From: Geert Uytterhoeven <[EMAIL PROTECTED]>
> > >
> > > Add a Disk Storage Driver for the PS3:
> >
> > Your patch
On Wed, Jul 18 2007, Andrew Morton wrote:
> On Mon, 16 Jul 2007 18:15:40 +0200
> Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
>
> > From: Geert Uytterhoeven <[EMAIL PROTECTED]>
> >
> > Add a Disk Storage Driver for the PS3:
>
> Your patchset significantly hits powerpc, scsi and block. So who g
On Mon, 16 Jul 2007 18:15:40 +0200
Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> From: Geert Uytterhoeven <[EMAIL PROTECTED]>
>
> Add a Disk Storage Driver for the PS3:
Your patchset significantly hits powerpc, scsi and block. So who gets to
merge this? Jens? James? Paul?
Me, I guess ;)
On Wed, 18 Jul 2007, Jan Engelhardt wrote:
> On Jul 16 2007 18:15, Geert Uytterhoeven wrote:
> >Add a Disk Storage Driver for the PS3:
> > - Implemented as a block device driver with a dynamic major
> > - Disk names (and partitions) are of the format ps3d%c(%u)
> > - Uses software scatter-gather
On Jul 16 2007 18:15, Geert Uytterhoeven wrote:
>
>Add a Disk Storage Driver for the PS3:
> - Implemented as a block device driver with a dynamic major
> - Disk names (and partitions) are of the format ps3d%c(%u)
> - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor
>
From: Geert Uytterhoeven <[EMAIL PROTECTED]>
Add a Disk Storage Driver for the PS3:
- Implemented as a block device driver with a dynamic major
- Disk names (and partitions) are of the format ps3d%c(%u)
- Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor
doesn't
21 matches
Mail list logo
