Re: [patch 1/3] tick: Remove pointless cpu valid check in hotplug code

2020-12-11 Thread Frederic Weisbecker
On Sat, Dec 12, 2020 at 01:16:12AM +0100, Thomas Gleixner wrote: > On Fri, Dec 11 2020 at 23:21, Frederic Weisbecker wrote: > > On Sun, Dec 06, 2020 at 10:12:54PM +0100, Thomas Gleixner wrote: > >> tick_handover_do_timer() which is invoked when a CPU is unplugged has a > >> @@ -407,17 +407,13 @@ EX

Re: [patch 1/3] tick: Remove pointless cpu valid check in hotplug code

2020-12-11 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 23:21, Frederic Weisbecker wrote: > On Sun, Dec 06, 2020 at 10:12:54PM +0100, Thomas Gleixner wrote: >> tick_handover_do_timer() which is invoked when a CPU is unplugged has a >> @@ -407,17 +407,13 @@ EXPORT_SYMBOL_GPL(tick_broadcast_oneshot >> /* >> * Transfer the do_time

Re: [patch 1/3] tick: Remove pointless cpu valid check in hotplug code

2020-12-11 Thread Frederic Weisbecker
On Sun, Dec 06, 2020 at 10:12:54PM +0100, Thomas Gleixner wrote: > tick_handover_do_timer() which is invoked when a CPU is unplugged has a > check for cpumask_first(cpu_online_mask) when it tries to hand over the > tick update duty. > > Checking the result of cpumask_first() there is pointless bec

Re: [patch 1/3] tick: Remove pointless cpu valid check in hotplug code

2020-12-11 Thread Frederic Weisbecker
On Sun, Dec 06, 2020 at 10:12:54PM +0100, Thomas Gleixner wrote: > tick_handover_do_timer() which is invoked when a CPU is unplugged has a > check for cpumask_first(cpu_online_mask) when it tries to hand over the > tick update duty. > > Checking the result of cpumask_first() there is pointless bec

Re: [patch 1/3] tick: Remove pointless cpu valid check in hotplug code

2020-12-07 Thread Thomas Gleixner
On Mon, Dec 07 2020 at 12:59, Peter Zijlstra wrote: > On Sun, Dec 06, 2020 at 10:12:54PM +0100, Thomas Gleixner wrote: > >> void tick_handover_do_timer(void) >> { >> +if (tick_do_timer_cpu == smp_processor_id()) >> +tick_do_timer_cpu = cpumask_first(cpu_online_mask); > > For the p

Re: [patch 1/3] tick: Remove pointless cpu valid check in hotplug code

2020-12-07 Thread Peter Zijlstra
On Sun, Dec 06, 2020 at 10:12:54PM +0100, Thomas Gleixner wrote: > void tick_handover_do_timer(void) > { > + if (tick_do_timer_cpu == smp_processor_id()) > + tick_do_timer_cpu = cpumask_first(cpu_online_mask); For the paranoid amongst us, would it make sense to add something lik

[patch 1/3] tick: Remove pointless cpu valid check in hotplug code

2020-12-06 Thread Thomas Gleixner
tick_handover_do_timer() which is invoked when a CPU is unplugged has a check for cpumask_first(cpu_online_mask) when it tries to hand over the tick update duty. Checking the result of cpumask_first() there is pointless because if the online mask is empty at this point, then this would be the last