Re: [patch 1/4] crypto/sha256.c: fix sparse warnings

2005-03-20 Thread Herbert Xu
Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > > crypto/sha256.c:61:9: warning: cast to restricted type > > Use CHECK="sparse -Wbitwise" to see it. Thanks. I've applied all four patches to crypto. I changed patch 4/4 slightly so that it reads +#define u32_in(x) le32_to_cpu(*(const __le32 *)(x))

Re: [patch 1/4] crypto/sha256.c: fix sparse warnings

2005-03-20 Thread Alexey Dobriyan
On Sunday 20 March 2005 10:32, Herbert Xu wrote: > [EMAIL PROTECTED] wrote: > > +++ kj-domen/crypto/sha256.c > > static inline void LOAD_OP(int I, u32 *W, const u8 *input) > > { > > - W[I] = __be32_to_cpu( ((u32*)(input))[I] ); > > + W[I] = __be32_to_cpu( ((__be32*)(input))[I] ); > > I

Re: [patch 1/4] crypto/sha256.c: fix sparse warnings

2005-03-19 Thread Herbert Xu
[EMAIL PROTECTED] wrote: > > diff -puN crypto/sha256.c~sparse-crypto_sha256 crypto/sha256.c > --- kj/crypto/sha256.c~sparse-crypto_sha256 2005-03-18 20:05:34.0 > +0100 > +++ kj-domen/crypto/sha256.c2005-03-18 20:05:34.0 +0100 > @@ -58,7 +58,7 @@ static inline u32 Maj(u32 x,

[patch 1/4] crypto/sha256.c: fix sparse warnings

2005-03-19 Thread domen
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/crypto/sha256.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN crypto/sha256.c~sparse-crypto_sha256 crypto/sha256.c --- kj/crypto/sha256.c~sparse-crypto_sha256 2005-03-18 20:05:34.0 +0100 +++ kj-do