Re: [patch 1/7] timers: Sanitize catchup_timer_jiffies() usage

2015-05-26 Thread Viresh Kumar
On 26-05-15, 22:50, Thomas Gleixner wrote: > 3) __run_timers() > >We only check on entry, which is silly, because base->timer_jiffies >can be behind - especially on NOHZ kernels - and if there is a >single deferrable timer somewhere between base->timer_jiffies and >jiffies we expir

[patch 1/7] timers: Sanitize catchup_timer_jiffies() usage

2015-05-26 Thread Thomas Gleixner
catchup_timer_jiffies() has been applied blindly to several functions without looking for possible better ways to do it. 1) internal_add_timer() Move the update to base->all_timers before we actually insert the timer into the wheel. 2) detach_if_pending() Again the update to base->all_