Re: [patch 1/8] isdn_bsdcomp.c - vfree() checking cleanups

Hi Domen, > On 07/03/05 00:07 +, Ralph Corderoy wrote: > > > - if (db->dict) { > > > - vfree (db->dict); > > > - db->dict = NULL; > > > - } > > > + vfree (db->dict); > > > + db->dict = NULL; > > > > Is it really worth always cal

Re: [patch 1/8] isdn_bsdcomp.c - vfree() checking cleanups

On Mon, Mar 07, 2005 at 01:21:33AM +0100, Domen Puncer wrote: > On 07/03/05 00:07 +, Ralph Corderoy wrote: > > > > Hi Domen, > > > > > - if (db->dict) { > > > - vfree (db->dict); > > > - db->dict = NULL; > > > - } > > > + vfree (db->dict

Re: [patch 1/8] isdn_bsdcomp.c - vfree() checking cleanups

On 07/03/05 00:07 +, Ralph Corderoy wrote: > > Hi Domen, > > > - if (db->dict) { > > - vfree (db->dict); > > - db->dict = NULL; > > - } > > + vfree (db->dict); > > + db->dict = NULL; > > Is it really worth always cal

Re: [patch 1/8] isdn_bsdcomp.c - vfree() checking cleanups

Hi Domen, > - if (db->dict) { > - vfree (db->dict); > - db->dict = NULL; > - } > + vfree (db->dict); > + db->dict = NULL; Is it really worth always calling vfree() which calls __vunmap() before db->dict is de

[patch 1/8] isdn_bsdcomp.c - vfree() checking cleanups

isdn_bsdcomp.c vfree() checking cleanups. Signed-off by: James Lamanna <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/isdn/i4l/isdn_bsdcomp.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff -puN drivers/isdn/i4l/isdn_bsdcom