Re: [patch 10/13] signal/timer/event fds v8 - eventfd core ...

2007-03-31 Thread Davide Libenzi
On Fri, 30 Mar 2007, Andrew Morton wrote: > On Fri, 30 Mar 2007 18:11:55 -0700 (PDT) Davide Libenzi > wrote: > > > > > > > + */ > > > > > > So it is the caller's responsibility to ensure that *file refers to an > > > eventfd file? > > > > In which function? I lost you ... > > > >

Re: [patch 10/13] signal/timer/event fds v8 - eventfd core ...

2007-03-31 Thread Davide Libenzi
On Fri, 30 Mar 2007, Andrew Morton wrote: On Fri, 30 Mar 2007 18:11:55 -0700 (PDT) Davide Libenzi davidel@xmailserver.org wrote: + */ So it is the caller's responsibility to ensure that *file refers to an eventfd file? In which function? I lost you ...

Re: [patch 10/13] signal/timer/event fds v8 - eventfd core ...

2007-03-30 Thread Andrew Morton
On Fri, 30 Mar 2007 18:11:55 -0700 (PDT) Davide Libenzi wrote: > > > > + */ > > > > So it is the caller's responsibility to ensure that *file refers to an > > eventfd file? > > In which function? I lost you ... > eventfd_signal() assumes that the passed in file* refers to an eventfd file.

Re: [patch 10/13] signal/timer/event fds v8 - eventfd core ...

2007-03-30 Thread Davide Libenzi
On Fri, 30 Mar 2007, Davide Libenzi wrote: > > Some architectures do not implement 64-bit get_user() > > copy_from_user it is, then ... That's messed up though. We do have put_user and we miss get_user. Bah... - Davide - To unsubscribe from this list: send the line "unsubscribe

Re: [patch 10/13] signal/timer/event fds v8 - eventfd core ...

2007-03-30 Thread Davide Libenzi
On Fri, 30 Mar 2007, Andrew Morton wrote: > > +struct eventfd_ctx { > > + spinlock_t lock; > > + wait_queue_head_t wqh; > > + __u64 count; > > +}; > > Again, can we borrow wqh.lock? > > `count' needs documentation - these things are key to understanding the > code. Added. > > + */ >

Re: [patch 10/13] signal/timer/event fds v8 - eventfd core ...

2007-03-30 Thread Andrew Morton
On Tue, 20 Mar 2007 11:37:14 -0700 Davide Libenzi wrote: > This is a very simple and light file descriptor, that can be used as > event wait/dispatch by userspace (both wait and dispatch) and by the > kernel (dispatch only). It can be used instead of pipe(2) in all cases > where those would

Re: [patch 10/13] signal/timer/event fds v8 - eventfd core ...

2007-03-30 Thread Andrew Morton
On Tue, 20 Mar 2007 11:37:14 -0700 Davide Libenzi davidel@xmailserver.org wrote: This is a very simple and light file descriptor, that can be used as event wait/dispatch by userspace (both wait and dispatch) and by the kernel (dispatch only). It can be used instead of pipe(2) in all cases

Re: [patch 10/13] signal/timer/event fds v8 - eventfd core ...

2007-03-30 Thread Davide Libenzi
On Fri, 30 Mar 2007, Andrew Morton wrote: +struct eventfd_ctx { + spinlock_t lock; + wait_queue_head_t wqh; + __u64 count; +}; Again, can we borrow wqh.lock? `count' needs documentation - these things are key to understanding the code. Added. + */ So it is the

Re: [patch 10/13] signal/timer/event fds v8 - eventfd core ...

2007-03-30 Thread Davide Libenzi
On Fri, 30 Mar 2007, Davide Libenzi wrote: Some architectures do not implement 64-bit get_user() copy_from_user it is, then ... That's messed up though. We do have put_user and we miss get_user. Bah... - Davide - To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [patch 10/13] signal/timer/event fds v8 - eventfd core ...

2007-03-30 Thread Andrew Morton
On Fri, 30 Mar 2007 18:11:55 -0700 (PDT) Davide Libenzi davidel@xmailserver.org wrote: + */ So it is the caller's responsibility to ensure that *file refers to an eventfd file? In which function? I lost you ... eventfd_signal() assumes that the passed in file* refers to an

[patch 10/13] signal/timer/event fds v8 - eventfd core ...

2007-03-20 Thread Davide Libenzi
This is a very simple and light file descriptor, that can be used as event wait/dispatch by userspace (both wait and dispatch) and by the kernel (dispatch only). It can be used instead of pipe(2) in all cases where those would simply be used to signal events. Their kernel overhead is much lower

[patch 10/13] signal/timer/event fds v8 - eventfd core ...

2007-03-20 Thread Davide Libenzi
This is a very simple and light file descriptor, that can be used as event wait/dispatch by userspace (both wait and dispatch) and by the kernel (dispatch only). It can be used instead of pipe(2) in all cases where those would simply be used to signal events. Their kernel overhead is much lower