Re: [patch 11/23] x86/x2apic: Split enable and setup function

2015-01-22 Thread Thomas Gleixner
On Fri, 16 Jan 2015, Borislav Petkov wrote: > On Thu, Jan 15, 2015 at 09:22:26PM -, Thomas Gleixner wrote: > > +/* Called from cpu_init() to enable x2apic on (secondary) cpus */ > > +void x2apic_setup(void) > > +{ > > + /* > > +* If x2apic is not in ON state, disable it if already enabled

Re: [patch 11/23] x86/x2apic: Split enable and setup function

2015-01-16 Thread Borislav Petkov
On Thu, Jan 15, 2015 at 09:22:26PM -, Thomas Gleixner wrote: > enable_x2apic() is a convoluted unreadable mess because it is used for > both enablement in early boot and for setup in cpu_init(). > > Split the code into x2apic_enable() for enablement and x2apic_setup() > for setup of (secondary

[patch 11/23] x86/x2apic: Split enable and setup function

2015-01-15 Thread Thomas Gleixner
enable_x2apic() is a convoluted unreadable mess because it is used for both enablement in early boot and for setup in cpu_init(). Split the code into x2apic_enable() for enablement and x2apic_setup() for setup of (secondary cpus). Make use of the new state tracking to simplify the logic. Signed-o