Re: [patch 16/20] XEN-paravirt: Add the Xen virtual console driver.

2007-01-18 Thread Jeremy Fitzhardinge
Pavel Machek wrote: > You have drivers/xen... so maybe arch/i386/xen is easier to type? > arch/i386/paravirt/xen would make some sense, too, but it looks too > deep to me. I think the exact placement of these files needs a bit of work. I don't much care about xen/ vs paravirt/xen vs

Re: [patch 16/20] XEN-paravirt: Add the Xen virtual console driver.

2007-01-18 Thread Jeremy Fitzhardinge
Pavel Machek wrote: You have drivers/xen... so maybe arch/i386/xen is easier to type? arch/i386/paravirt/xen would make some sense, too, but it looks too deep to me. I think the exact placement of these files needs a bit of work. I don't much care about xen/ vs paravirt/xen vs paravirt-xen/,

Re: [patch 16/20] XEN-paravirt: Add the Xen virtual console driver.

2007-01-17 Thread Pavel Machek
Hi! > This provides a bootstrap and ongoing emergency console which is > intended to be available from very early during boot and at all times > thereafter, in contrast with alternatives such as UDP-based syslogd, > or logging in via ssh. The protocol is based on a simple shared-memory > ring

Re: [patch 16/20] XEN-paravirt: Add the Xen virtual console driver.

2007-01-17 Thread Pavel Machek
Hi! This provides a bootstrap and ongoing emergency console which is intended to be available from very early during boot and at all times thereafter, in contrast with alternatives such as UDP-based syslogd, or logging in via ssh. The protocol is based on a simple shared-memory ring buffer.

Re: [patch 16/20] XEN-paravirt: Add the Xen virtual console driver.

2007-01-13 Thread Jeremy Fitzhardinge
Alan wrote: > Andrew: No objection to this tty stuff being merged provided the bugs > noted above (not worried about the sign stuff) are fixed before it goes > on to Linus. > Thanks for the comments. I'll see if I can put together a fixup patch before LCA, but possibly not. J - To

Re: [patch 16/20] XEN-paravirt: Add the Xen virtual console driver.

2007-01-13 Thread Alan
> +#endif > + tty_insert_flip_char(xencons_tty, buf[i], 0); Please use the defines like TTY_NORMAL not just 0. > + if ((xencons_tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) && > + (xencons_tty->ldisc.write_wakeup != NULL)) > +

[patch 16/20] XEN-paravirt: Add the Xen virtual console driver.

2007-01-13 Thread Jeremy Fitzhardinge
This provides a bootstrap and ongoing emergency console which is intended to be available from very early during boot and at all times thereafter, in contrast with alternatives such as UDP-based syslogd, or logging in via ssh. The protocol is based on a simple shared-memory ring buffer.

[patch 16/20] XEN-paravirt: Add the Xen virtual console driver.

2007-01-13 Thread Jeremy Fitzhardinge
This provides a bootstrap and ongoing emergency console which is intended to be available from very early during boot and at all times thereafter, in contrast with alternatives such as UDP-based syslogd, or logging in via ssh. The protocol is based on a simple shared-memory ring buffer.

Re: [patch 16/20] XEN-paravirt: Add the Xen virtual console driver.

2007-01-13 Thread Alan
+#endif + tty_insert_flip_char(xencons_tty, buf[i], 0); Please use the defines like TTY_NORMAL not just 0. + if ((xencons_tty-flags (1 TTY_DO_WRITE_WAKEUP)) + (xencons_tty-ldisc.write_wakeup != NULL)) +

Re: [patch 16/20] XEN-paravirt: Add the Xen virtual console driver.

2007-01-13 Thread Jeremy Fitzhardinge
Alan wrote: Andrew: No objection to this tty stuff being merged provided the bugs noted above (not worried about the sign stuff) are fixed before it goes on to Linus. Thanks for the comments. I'll see if I can put together a fixup patch before LCA, but possibly not. J - To