Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

Jeremy Fitzhardinge <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> I'm pretty certain we explicitly drop the weird GNU note that >> is automatically generated by gcc and specifies something informational. >> > But that's something else again, since it appears as a PT_GNU_STACK phdr.

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

Eric W. Biederman wrote: > I'm pretty certain we explicitly drop the weird GNU note that > is automatically generated by gcc and specifies something informational. > But that's something else again, since it appears as a PT_GNU_STACK phdr. > I don't think anything we are doing is wrong but ld g

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

Jeremy Fitzhardinge <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> Reasonable and it's probably worth letting the binutils developer know. >> I do agree that it is weird. It might be that something in binutils >> doesn't like us dropping some of the notes. >> > > What do you mean b

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

Eric W. Biederman wrote: > Reasonable and it's probably worth letting the binutils developer know. > I do agree that it is weird. It might be that something in binutils > doesn't like us dropping some of the notes. > What do you mean by "dropping some of the notes"? I think the only notes (a

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

Jeremy Fitzhardinge <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> Ok. If that is all this may be a difference that makes no difference. >> binutils has a bad habit of looking at sections (which are fully >> optional) instead of segments on ET_EXEC and ET_DYN objects. Only >> ET_REL o

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

Eric W. Biederman wrote: > Ok. If that is all this may be a difference that makes no difference. > binutils has a bad habit of looking at sections (which are fully > optional) instead of segments on ET_EXEC and ET_DYN objects. Only > ET_REL objects (.o files) are required to have sections. >

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

Jeremy Fitzhardinge <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> Well I did a little by hand parsing and the not I parsed looked ok. >> >> How does the output differ from a what you get when xen-head.S is >> included? >> > Ah! > > The .notes section gets SHT_NOTE in vmlinux when xe

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

Eric W. Biederman wrote: > Jeremy Fitzhardinge <[EMAIL PROTECTED]> writes: > > There need to be alignment directives for the page aligned chunks. > OK. > Placing the page aligned chunks in a special section is nice in that > it ensures the linker packs everything tightly but should be > comple

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

Eric W. Biederman wrote: > Well I did a little by hand parsing and the not I parsed looked ok. > > How does the output differ from a what you get when xen-head.S is > included? > Ah! The .notes section gets SHT_NOTE in vmlinux when xen-head.S is included; PROGBITS when linked. I tried putting

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

Jeremy Fitzhardinge <[EMAIL PROTECTED]> writes: There need to be alignment directives for the page aligned chunks. Placing the page aligned chunks in a special section is nice in that it ensures the linker packs everything tightly but should be completely unnecessary if the alignment is correct.

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

Jeremy Fitzhardinge <[EMAIL PROTECTED]> writes: > Andi Kleen wrote: >>> +#ifdef CONFIG_XEN >>> +#include "../xen/xen-head.S" >>> +#endif >>> >> >> Can this really not be linked separately? > > I did a patch to do this (attached). In principle it should be pretty > simple, but I think I'm ru

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

Andi Kleen wrote: >> +#ifdef CONFIG_XEN >> +#include "../xen/xen-head.S" >> +#endif >> > > Can this really not be linked separately? I did a patch to do this (attached). In principle it should be pretty simple, but I think I'm running into toolchain issues. If I link xen-head.S separately

[Xen-devel] Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

>>> @@ -528,7 +532,7 @@ ENTRY(_stext) >>> /* >>> * BSS section >>> */ >>> -.section ".bss.page_aligned","w" >>> +.section ".bss.page_aligned" >>> >> >> Why? >> > >I got complaints about section attribute mismatches without it. Then perhaps ... "aw" is meant? >>> +fastcall unsigned l

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

Andi Kleen wrote: >> --- a/arch/i386/kernel/entry.S >> +++ b/arch/i386/kernel/entry.S >> @@ -1001,6 +1001,83 @@ ENTRY(kernel_thread_helper) >> CFI_ENDPROC >> ENDPROC(kernel_thread_helper) >> >> +#ifdef CONFIG_XEN >> +/* Xen only supports sysenter/sysexit in ring0 guests, >> + and only if

Re: [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen

> --- a/arch/i386/kernel/entry.S > +++ b/arch/i386/kernel/entry.S > @@ -1001,6 +1001,83 @@ ENTRY(kernel_thread_helper) > CFI_ENDPROC > ENDPROC(kernel_thread_helper) > > +#ifdef CONFIG_XEN > +/* Xen only supports sysenter/sysexit in ring0 guests, > + and only if it the guest asks for it.