Re: [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks

2017-09-11 Thread David Rientjes
On Mon, 11 Sep 2017, Vlastimil Babka wrote: > > Yes, any page where compound_order(page) == pageblock_order would probably > > benefit from the same treatment. I haven't encountered such an issue, > > however, so I thought it was best to restrict it only to hugetlb: hugetlb > > memory usually

Re: [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks

2017-09-10 Thread Vlastimil Babka
On 09/11/2017 03:12 AM, David Rientjes wrote: > On Wed, 23 Aug 2017, Vlastimil Babka wrote: > >>> diff --git a/mm/compaction.c b/mm/compaction.c >>> --- a/mm/compaction.c >>> +++ b/mm/compaction.c >>> @@ -217,6 +217,20 @@ static void reset_cached_positions(struct zone *zone) >>>

Re: [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks

2017-09-10 Thread David Rientjes
On Fri, 1 Sep 2017, Vlastimil Babka wrote: > The pageblock_skip_persistent() function checks for HugeTLB pages of pageblock > order. When clearing pageblock skip bits for compaction, the bits are not > cleared for such pageblocks, because they cannot contain base pages suitable > for migration, no

Re: [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks

2017-09-10 Thread David Rientjes
On Wed, 23 Aug 2017, Vlastimil Babka wrote: > > diff --git a/mm/compaction.c b/mm/compaction.c > > --- a/mm/compaction.c > > +++ b/mm/compaction.c > > @@ -217,6 +217,20 @@ static void reset_cached_positions(struct zone *zone) > > pageblock_start_pfn(zone_end_pfn(zone) -

Re: [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks

2017-09-01 Thread Vlastimil Babka
On 08/23/2017 10:41 AM, Vlastimil Babka wrote: > On 08/16/2017 01:39 AM, David Rientjes wrote: >> It is pointless to migrate hugetlb memory as part of memory compaction if >> the hugetlb size is equal to the pageblock order. No defragmentation is >> occurring in this condition. >> >> It is also po

Re: [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks

2017-08-23 Thread Vlastimil Babka
On 08/16/2017 01:39 AM, David Rientjes wrote: > It is pointless to migrate hugetlb memory as part of memory compaction if > the hugetlb size is equal to the pageblock order. No defragmentation is > occurring in this condition. > > It is also pointless to for the freeing scanner to scan a pagebloc

Re: [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks

2017-08-18 Thread Michal Hocko
I am getting mm/compaction.c: In function 'isolate_freepages_block': mm/compaction.c:469:4: error: implicit declaration of function 'pageblock_skip_persistent' [-Werror=implicit-function-declaration] if (pageblock_skip_persistent(page, order)) { ^ mm/compaction.c:470:5: error: implicit de

[patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks

2017-08-15 Thread David Rientjes
It is pointless to migrate hugetlb memory as part of memory compaction if the hugetlb size is equal to the pageblock order. No defragmentation is occurring in this condition. It is also pointless to for the freeing scanner to scan a pageblock where a hugetlb page is pinned. Unconditionally skip