Re: [patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-02-23 Thread Michal Hocko
On Mon 23-02-15 06:13:52, Sasha Levin wrote: > Hi Johannes, > > On 01/20/2015 10:31 AM, Johannes Weiner wrote: > > Introduce the basic control files to account, partition, and limit > > memory using cgroups in default hierarchy mode. > > I'm seeing the following while fuzzing: Already fixed by h

Re: [patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-02-23 Thread Sasha Levin
Hi Johannes, On 01/20/2015 10:31 AM, Johannes Weiner wrote: > Introduce the basic control files to account, partition, and limit > memory using cgroups in default hierarchy mode. I'm seeing the following while fuzzing: [ 5634.427361] GPF could be caused by NULL-ptr deref or user memory access ge

Re: [patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-01-20 Thread Michal Hocko
On Tue 20-01-15 10:31:55, Johannes Weiner wrote: > Introduce the basic control files to account, partition, and limit > memory using cgroups in default hierarchy mode. > > This interface versioning allows us to address fundamental design > issues in the existing memory cgroup interface, further ex

[patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-01-20 Thread Johannes Weiner
Introduce the basic control files to account, partition, and limit memory using cgroups in default hierarchy mode. This interface versioning allows us to address fundamental design issues in the existing memory cgroup interface, further explained below. The old interface will be maintained indefi

Re: [patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-01-15 Thread Michal Hocko
On Wed 14-01-15 12:19:44, Johannes Weiner wrote: > On Wed, Jan 14, 2015 at 04:34:25PM +0100, Michal Hocko wrote: > > On Thu 08-01-15 23:15:04, Johannes Weiner wrote: [...] > > > @@ -2322,6 +2325,12 @@ static bool shrink_zone(struct zone *zone, struct > > > scan_control *sc, > > >

Re: [patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-01-14 Thread Johannes Weiner
On Wed, Jan 14, 2015 at 04:34:25PM +0100, Michal Hocko wrote: > On Thu 08-01-15 23:15:04, Johannes Weiner wrote: > [...] > > @@ -2353,6 +2353,22 @@ done_restock: > > css_get_many(&memcg->css, batch); > > if (batch > nr_pages) > > refill_stock(memcg, batch - nr_pages); > > + /*

Re: [patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-01-14 Thread Michal Hocko
I have overlooked the `none' setting... On Thu 08-01-15 23:15:04, Johannes Weiner wrote: [...] > +static int memory_low_show(struct seq_file *m, void *v) > +{ > + struct mem_cgroup *memcg = mem_cgroup_from_css(seq_css(m)); > + unsigned long low = ACCESS_ONCE(memcg->low); > + > + if (lo

Re: [patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-01-14 Thread Johannes Weiner
On Tue, Jan 13, 2015 at 03:20:08PM -0800, Greg Thelen wrote: > > On Thu, Jan 08 2015, Johannes Weiner wrote: > > > Introduce the basic control files to account, partition, and limit > > memory using cgroups in default hierarchy mode. > > > > This interface versioning allows us to address fundamen

Re: [patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-01-14 Thread Michal Hocko
On Thu 08-01-15 23:15:04, Johannes Weiner wrote: [...] > @@ -2353,6 +2353,22 @@ done_restock: > css_get_many(&memcg->css, batch); > if (batch > nr_pages) > refill_stock(memcg, batch - nr_pages); > + /* > + * If the hierarchy is above the normal consumption range,

Re: [patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-01-14 Thread Vladimir Davydov
On Thu, Jan 08, 2015 at 11:15:04PM -0500, Johannes Weiner wrote: > - memory.low configures the lower end of the cgroup's expected > memory consumption range. The kernel considers memory below that > boundary to be a reserve - the minimum that the workload needs in > order to make for

Re: [patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-01-13 Thread Greg Thelen
On Thu, Jan 08 2015, Johannes Weiner wrote: > Introduce the basic control files to account, partition, and limit > memory using cgroups in default hierarchy mode. > > This interface versioning allows us to address fundamental design > issues in the existing memory cgroup interface, further explai

Re: [patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-01-13 Thread Johannes Weiner
On Tue, Jan 13, 2015 at 12:52:58PM -0800, Andrew Morton wrote: > On Tue, 13 Jan 2015 10:50:40 -0500 Johannes Weiner wrote: > > > On Mon, Jan 12, 2015 at 03:37:16PM -0800, Andrew Morton wrote: > > > This all sounds pretty major. How much trouble is this change likely to > > > cause existing memcg

Re: [patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-01-13 Thread Andrew Morton
On Tue, 13 Jan 2015 10:50:40 -0500 Johannes Weiner wrote: > On Mon, Jan 12, 2015 at 03:37:16PM -0800, Andrew Morton wrote: > > On Thu, 8 Jan 2015 23:15:04 -0500 Johannes Weiner > > wrote: > > > > > Introduce the basic control files to account, partition, and limit > > > memory using cgroups i

Re: [patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-01-13 Thread Johannes Weiner
On Mon, Jan 12, 2015 at 03:37:16PM -0800, Andrew Morton wrote: > On Thu, 8 Jan 2015 23:15:04 -0500 Johannes Weiner wrote: > > > Introduce the basic control files to account, partition, and limit > > memory using cgroups in default hierarchy mode. > > > > This interface versioning allows us to a

Re: [patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-01-12 Thread Andrew Morton
On Thu, 8 Jan 2015 23:15:04 -0500 Johannes Weiner wrote: > Introduce the basic control files to account, partition, and limit > memory using cgroups in default hierarchy mode. > > This interface versioning allows us to address fundamental design > issues in the existing memory cgroup interface,

[patch 2/2] mm: memcontrol: default hierarchy interface for memory

2015-01-08 Thread Johannes Weiner
Introduce the basic control files to account, partition, and limit memory using cgroups in default hierarchy mode. This interface versioning allows us to address fundamental design issues in the existing memory cgroup interface, further explained below. The old interface will be maintained indefi